https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cbalint13 wrote:
@DavidSpickett
Thank you for the review time, will address all the concerns and be back with a
re-review request.
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -1016,7 +1017,8 @@ TEST(TargetParserTest, ARMPrintSupportedExtensions) {
outs().flush();
testing::internal::CaptureStdout();
- ARM::PrintSupportedExtensions();
+ std::map EmptyMap;
cbalint13 wrote:
Will address this, even by adding a dummy
@@ -600,11 +601,17 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple
, StringRef MArch) {
llvm_unreachable("invalid arch name");
}
-void ARM::PrintSupportedExtensions() {
+void ARM::PrintSupportedExtensions(std::map llvmDescMap)
{
outs() << "All available -march
@@ -11,11 +11,13 @@
//
//===--===//
-#include "llvm/TargetParser/AArch64TargetParser.h"
+#include "llvm/Support/Error.h"
#include "llvm/Support/raw_ostream.h"
+#include
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,11 +11,13 @@
//
//===--===//
-#include "llvm/TargetParser/AArch64TargetParser.h"
+#include "llvm/Support/Error.h"
cbalint13 wrote:
It was for format()```, will double-check to
@@ -210,24 +210,33 @@ static void verifyTables() {
#endif
}
-void llvm::riscvExtensionsHelp() {
+void llvm::riscvExtensionsHelp(std::map llvmDescMap) {
+
outs() << "All available -march extensions for RISC-V\n\n";
- outs() << '\t' << left_justify("Name", 20) <<
@@ -210,24 +210,33 @@ static void verifyTables() {
#endif
}
-void llvm::riscvExtensionsHelp() {
+void llvm::riscvExtensionsHelp(std::map llvmDescMap) {
+
outs() << "All available -march extensions for RISC-V\n\n";
- outs() << '\t' << left_justify("Name", 20) <<
@@ -198,13 +199,21 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
@@ -198,13 +199,21 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
@@ -600,11 +601,17 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple
, StringRef MArch) {
llvm_unreachable("invalid arch name");
}
-void ARM::PrintSupportedExtensions() {
+void ARM::PrintSupportedExtensions(std::map llvmDescMap)
{
outs() << "All available -march
@@ -1016,7 +1017,8 @@ TEST(TargetParserTest, ARMPrintSupportedExtensions) {
outs().flush();
testing::internal::CaptureStdout();
- ARM::PrintSupportedExtensions();
+ std::map EmptyMap;
DavidSpickett wrote:
All tests for this should include at least 1
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,11 +11,13 @@
//
//===--===//
-#include "llvm/TargetParser/AArch64TargetParser.h"
+#include "llvm/Support/Error.h"
#include "llvm/Support/raw_ostream.h"
+#include
@@ -11,11 +11,13 @@
//
//===--===//
-#include "llvm/TargetParser/AArch64TargetParser.h"
+#include "llvm/Support/Error.h"
DavidSpickett wrote:
Why do we need to include Support/Error now?
@@ -600,11 +601,17 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple
, StringRef MArch) {
llvm_unreachable("invalid arch name");
}
-void ARM::PrintSupportedExtensions() {
+void ARM::PrintSupportedExtensions(std::map llvmDescMap)
{
outs() << "All available -march
@@ -600,11 +601,17 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple
, StringRef MArch) {
llvm_unreachable("invalid arch name");
}
-void ARM::PrintSupportedExtensions() {
+void ARM::PrintSupportedExtensions(std::map llvmDescMap)
{
outs() << "All available -march
https://github.com/DavidSpickett requested changes to this pull request.
This looks really nice. Two overall things:
Now that ARM and AArch64 print more than just names, they should have column
headers like RISC-V does. Name / Description
The clang test case
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 231c93881e7719b447db3f15a37ad6cecede3be3 Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Tue, 19 Sep 2023 02:59:40 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 671cbe3bbb0d201d6d938dbc0e2993b074dd1001 Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Tue, 19 Sep 2023 02:13:19 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 created
https://github.com/llvm/llvm-project/pull/66715
Enables summary descriptions along with the names of the feature.
Descriptions here are simply looked up via the available llvm tablegen data.
The full prints from CLI are here:
101 - 123 of 123 matches
Mail list logo
