Re: PATCH: re-enable OpenCL extensions

2017-01-20 Thread Kalle Raiskila via cfe-commits
On 19.01.2017 23:43, Liu, Yaxun (Sam) wrote: I think the supported extensions for a target should be as accurate as possible, for it to be useful. Setting all extensions to be supported on all targets will defeat its purpose. I agree on the first part, but arrive at the exact opposite

RE: PATCH: re-enable OpenCL extensions

2017-01-19 Thread Liu, Yaxun (Sam) via cfe-commits
n...@arm.com> Subject: RE: PATCH: re-enable OpenCL extensions As mentioned on cfe-dev as well, although it doesn't seem too critical it is generally not logical to enable all extensions by default because most of the targets don't even support OpenCL. But I understand your situation wit

RE: PATCH: re-enable OpenCL extensions

2017-01-19 Thread Anastasia Stulova via cfe-commits
mmits-boun...@lists.llvm.org] On Behalf Of Kalle Raiskila via cfe-commits Sent: 19 January 2017 08:03 To: cfe-commits@lists.llvm.org Subject: PATCH: re-enable OpenCL extensions Hi, I noticed a change from clang 3.8 to 3.9, that it disabled all OpenCL extension pragmas per default. This broke pocl o

PATCH: re-enable OpenCL extensions

2017-01-19 Thread Kalle Raiskila via cfe-commits
Hi, I noticed a change from clang 3.8 to 3.9, that it disabled all OpenCL extension pragmas per default. This broke pocl on e.g. ARM for LLVM 3.9 (https://github.com/pocl/pocl/issues/409). Example: $ echo "#pragma OPENCL EXTENSION cl_khr_icd: enable" > hello.cl $ clang -emit-llvm -x cl -o