r246803, thanks!
2015-09-03 23:16 GMT+03:00 Reid Kleckner :
> LGTM, but I would expand on the comment a bit:
> // The ABI says: "It is suggested that it be emitted in the same
> COMDAT group
> // as the associated data object." In practice, this doesn't work for
> non-ELF object format
LGTM, but I would expand on the comment a bit:
// The ABI says: "It is suggested that it be emitted in the same
COMDAT group
// as the associated data object." In practice, this doesn't work for
non-ELF object formats, so only do it for ELF.
On Thu, Sep 3, 2015 at 11:31 AM, Rafael Espínd
I fully trust Reid review on this, so OK with me.
On 3 September 2015 at 14:04, Yaron Keren wrote:
> http://llvm.org/pr23472
>
> As suggested by Reid, OK to commit?
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
http://llvm.org/pr23472
As suggested by Reid, OK to commit?
Index: tools/clang/lib/CodeGen/ItaniumCXXABI.cpp
===
--- tools/clang/lib/CodeGen/ItaniumCXXABI.cpp (revision 246575)
+++ tools/clang/lib/CodeGen/ItaniumCXXABI.cpp (workin
