Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-10-01 Thread Josh Stone via cfe-commits
On 10/1/21 2:59 PM, Josh Stone wrote: > On 9/30/21 4:15 PM, Mehdi AMINI via llvm-dev wrote: >> On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote: >>> >>> >>> >>> On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: Does something like Rust's "bors" bot satisfy the herald rules need? >>> >>>

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-10-01 Thread Josh Stone via cfe-commits
On 9/30/21 4:15 PM, Mehdi AMINI via llvm-dev wrote: > On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote: >> >> >> >> On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: >>> >>> Does something like Rust's "bors" bot satisfy the herald rules need? >> >> >> >> sorry, maybe I was thinking of the

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-10-01 Thread Christian Kühnel via cfe-commits
Hi folks, Arcanist not working any longer is really unfortunate. Phroge also has a fork of Arcanist, however I haven't seen any SSL-related patches: https://we.phorge.it/source/arcanist/browse/master/ 1) Replacement for Herald rules. I suppose the notification problem is solvable. I just took

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-10-01 Thread Christian Kühnel via cfe-commits
y breakages that come along). > >> > >> > >> > >> Thanks, > >> > >>Chris Tetreault > >> > >> > >> > >> From: llvm-dev On Behalf Of > MyDeveloper Day via llvm-dev > >> Sent: Wednesday, August 18,

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-10-01 Thread Brian Cain via cfe-commits
question >> might have just become a bit more urgent. >> >> >> >> >> >> >> >> I suppose in the short-term, we could fork the phabricator repos in >> order to fix little issues like this. Alternately, we should probably stop >> r

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-10-01 Thread Brian Cain via cfe-commits
; I suppose in the short-term, we could fork the phabricator repos in > order to fix little issues like this. Alternately, we should probably stop > recommending arcanist (unless we want to provide instructions on how to fix > any breakages that come along). > >> > >>

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-10-01 Thread Brian Cain via cfe-commits
AM > *To:* llvm-dev ; cfe-commits < > cfe-commits@lists.llvm.org> > *Subject:* [llvm-dev] Phabricator Creator Pulling the Plug > > > > *WARNING:* This email originated from outside of Qualcomm. Please be wary > of any links or attachments, and do not enable macros. >

RE: [llvm-dev] Phabricator Creator Pulling the Plug

2021-10-01 Thread Chris Tetreault via cfe-commits
). Thanks, Chris Tetreault From: llvm-dev On Behalf Of MyDeveloper Day via llvm-dev Sent: Wednesday, August 18, 2021 10:17 AM To: llvm-dev ; cfe-commits Subject: [llvm-dev] Phabricator Creator Pulling the Plug WARNING: This email originated from outside of Qualcomm. Please be wary of any links

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-10-01 Thread James Henderson via cfe-commits
+1 to the review experience in Github being far worse than Phabricator, with basically all my specific concerns already being covered in this thread. I just wanted to add that our downstream LLVM port is based in a local Github Enterprise instance, and I find it far harder to review and respond to

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-09-30 Thread Mehdi AMINI via cfe-commits
On Thu, Sep 30, 2021 at 8:05 PM Hubert Tong wrote: > > On Thu, Sep 30, 2021 at 6:56 PM Mehdi AMINI via cfe-commits > wrote: >> >> We talked about this with the IWG (Infrastructure Working Group) just >> last week coincidentally. >> Two major blocking tracks that were identified at the

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-09-30 Thread Hubert Tong via cfe-commits
On Thu, Sep 30, 2021 at 6:56 PM Mehdi AMINI via cfe-commits < cfe-commits@lists.llvm.org> wrote: > We talked about this with the IWG (Infrastructure Working Group) just > last week coincidentally. > Two major blocking tracks that were identified at the roundtable > during the LLVM Dev Meeting

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-09-30 Thread Mehdi AMINI via cfe-commits
gt;> >>> >> >>> >> I know that arc is not universally used, but I think it’s a serious blow >>> >> to many people’s workflows. I think that MyDeveloperDay’s question might >>> >> have just become a bit more urgent. >>> >> >>&

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-09-30 Thread Mehdi AMINI via cfe-commits
; >> >> Thanks, >> >>Chris Tetreault >> >> >> >> From: llvm-dev On Behalf Of MyDeveloper >> Day via llvm-dev >> Sent: Wednesday, August 18, 2021 10:17 AM >> To: llvm-dev ; cfe-commits >> >> Subject: [llvm-dev] Phabricat

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-08-24 Thread Renato Golin via cfe-commits
On Tue, 24 Aug 2021 at 17:30, James Y Knight wrote: > Yes, the Gerrit hosting which Go uses ("googlesource.com") only permits a > google-account login as a matter of policy. But that's not a restriction of > Gerrit itself -- it can perfectly well be configured to use a github login. > Ah,

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-08-24 Thread James Y Knight via cfe-commits
On Tue, Aug 24, 2021 at 7:33 AM Renato Golin wrote: > The main problem with that (Go) solution is that the Gerrit install > doesn't single-sign-on with Github accounts, it asked me for my Google > account. We shouldn't ask people to create more accounts if we want > integration with Github. I

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-08-24 Thread Aaron Ballman via cfe-commits
On Tue, Aug 24, 2021 at 8:18 AM Renato Golin wrote: > > On Tue, 24 Aug 2021 at 12:49, Aaron Ballman wrote: >> >> > A minor issue is that the messages Gerrit sends to Github are a bit >> > pointless "Message from PersonA: (1 comment)". It would be better if the >> > integration either works

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-08-24 Thread Renato Golin via cfe-commits
On Tue, 24 Aug 2021 at 12:49, Aaron Ballman wrote: > > A minor issue is that the messages Gerrit sends to Github are a bit > pointless "Message from PersonA: (1 comment)". It would be better if the > integration either works (like adding comments to a specific line or > updating the commits) or

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-08-24 Thread Aaron Ballman via cfe-commits
On Tue, Aug 24, 2021 at 7:33 AM Renato Golin via cfe-commits wrote: > > On Mon, 23 Aug 2021 at 18:56, James Y Knight wrote: >> >> If phabricator/phorge do turn out to be non-viable in the future, I think we >> may want to reopen the option of moving to Gerrit for the primary >> code-review

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-08-24 Thread Renato Golin via cfe-commits
On Mon, 23 Aug 2021 at 18:56, James Y Knight wrote: > If phabricator/phorge do turn out to be non-viable in the future, I think > we may want to reopen the option of moving to Gerrit for the primary > code-review platform. > > I'll note that the Golang folks are using Gerrit as their review

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-08-23 Thread James Y Knight via cfe-commits
If phabricator/phorge do turn out to be non-viable in the future, I think we may want to reopen the option of moving to Gerrit for the primary code-review platform. I'll note that the Golang folks are using Gerrit as their review platform, and they have a GitHub bot setup to translate GH

Re: [llvm-dev] Phabricator Creator Pulling the Plug

2021-08-23 Thread Renato Golin via cfe-commits
On Wed, 18 Aug 2021 at 18:17, MyDeveloper Day via llvm-dev < llvm-...@lists.llvm.org> wrote: > But unless I missed this, was there any discussion regarding the recent > "Winding Down" announcement of Phabricator? and what it might mean for us > in LLVM > I think we have our own self-hosted

Phabricator Creator Pulling the Plug

2021-08-18 Thread MyDeveloper Day via cfe-commits
All I'm a massive fan of Phabricator, and I know there is often lots of contentious discussion about its relative merits vs github, But unless I missed this, was there any discussion regarding the recent "Winding Down" announcement of Phabricator? and what it might mean for us in LLVM See: