dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
s.egerton updated this revision to Diff 36252.
s.egerton added a comment.
Responded to comments made on the mailing list.
http://reviews.llvm.org/D13100
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/
On Wed, Sep 30, 2015 at 02:19:58PM +, Daniel Sanders via cfe-commits wrote:
> Hi,
>
> Sorry for the slow reply. I'm a bit behind on cfe-commits and it seems I
> dropped out of the CC list so it didn't land in my inbox.
>
> Do you mean something like this?:
> for (...) {
> ...
>
e.
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
> Of Joerg Sonnenberger via cfe-commits
> Sent: 24 September 2015 13:27
> To: cfe-commits@lists.llvm.org
> Subject: Re: [PATCH] D13100: [mips] Separated mips specific -Wa options,
On Thu, Sep 24, 2015 at 10:22:29AM +, Daniel Sanders via cfe-commits wrote:
> I'm thinking something like:
I think we really want to have an outer case, platform specific -Wa
options are quite common. Only x86 is mostly getting by without them so
far. I also think the switch is not that diffic
dsanders added subscribers: rengolin, joerg.
dsanders added a comment.
+Renato and Joerg
I was going to say I think it's ok and the optimizer should be smart enough to
factor out the common IsMips check but I've just realized there may be a better
way. The current code is using an else after an
