Filipe
> Cabecinhas
> *Sent:* Wednesday, October 14, 2015 6:11 AM
> *To:* Romanova, Katya
> *Cc:* Sean Silva; Eric Christopher;
> reviews+d13482+public+a1a9627af638c...@reviews.llvm.org; Alex Rosenberg;
> Robinson, Paul; Jonathan Roelofs; Bedwell, Greg;
> pierregoussea...@gmail.
l.com;
> Jonathan Roelofs; Bedwell, Greg; pierregoussea...@gmail.com; Anton
> Korobeynikov; Takumi NAKAMURA; cfe-commits
> *Subject:* Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain
>
>
>
>
>
>
>
> On Tue, Oct 13, 2015 at 11:40 PM, Eric Christopher
> wro
ristopher;
reviews+d13482+public+a1a9627af638c...@reviews.llvm.org; Alex Rosenberg;
Robinson, Paul; Jonathan Roelofs; Bedwell, Greg; pierregoussea...@gmail.com;
Anton Korobeynikov; Takumi NAKAMURA; cfe-commits
Subject: Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain
Hi all,
I have harn
;
Jonathan Roelofs; Bedwell, Greg;
pierregoussea...@gmail.com<mailto:pierregoussea...@gmail.com>; Anton
Korobeynikov; Takumi NAKAMURA; cfe-commits
Subject: Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain
On Tue, Oct 13, 2015 at 11:40 PM, Eric Christopher
mailto:echri...@gmail.c
; *Cc:* reviews+d13482+public+a1a9627af638c...@reviews.llvm.org; Romanova,
> Katya; Alex Rosenberg; Robinson, Paul; filcab+llvm.phabrica...@gmail.com;
> Jonathan Roelofs; Bedwell, Greg; pierregoussea...@gmail.com; Anton
> Korobeynikov; Takumi NAKAMURA; cfe-commits
> *Subject:* Re: [PAT
Subject: Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain
On Tue, Oct 13, 2015 at 11:40 PM, Eric Christopher
mailto:echri...@gmail.com>> wrote:
On Tue, Oct 13, 2015 at 11:38 PM Sean Silva
mailto:chisophu...@gmail.com>> wrote:
On Tue, Oct 13, 2015 at 11:33 PM, Eric
On Tue, Oct 13, 2015 at 11:40 PM, Eric Christopher
wrote:
>
>
> On Tue, Oct 13, 2015 at 11:38 PM Sean Silva wrote:
>
>> On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher
>> wrote:
>>
>>> It was already reverted, but I agree, let's get this fixed first.
>>>
>>
>> It was reintroduced in r250252.
On Tue, Oct 13, 2015 at 11:38 PM Sean Silva wrote:
> On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher
> wrote:
>
>> It was already reverted, but I agree, let's get this fixed first.
>>
>
> It was reintroduced in r250252. It is breaking
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-
On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher
wrote:
> It was already reverted, but I agree, let's get this fixed first.
>
It was reintroduced in r250252. It is breaking
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/1362
-- Sean Silva
>
> Thanks!
>
>
It was already reverted, but I agree, let's get this fixed first.
Thanks!
-eric
On Tue, Oct 13, 2015 at 11:33 PM Sean Silva wrote:
> On Tue, Oct 13, 2015 at 7:51 PM, Katya Romanova <
> katya_roman...@playstation.sony.com> wrote:
>
>> kromanova added a comment.
>>
>> Hi,
>>
>> The initial PS4 p
On Tue, Oct 13, 2015 at 7:51 PM, Katya Romanova <
katya_roman...@playstation.sony.com> wrote:
> kromanova added a comment.
>
> Hi,
>
> The initial PS4 patch caused a test failure (debug-options.c) on the PS4
> bot. I suspect that I know why the problem happens, but I'm not sure what
> will be the
kromanova added a comment.
Hi,
The initial PS4 patch caused a test failure (debug-options.c) on the PS4 bot. I
suspect that I know why the problem happens, but I'm not sure what will be the
best way to handle it. If someone knows how to fix this test more "elegantly",
I would appreciate their
tfiala added a comment.
Ah nice. Thanks!
-Todd
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ah nice. Thanks!
-Todd
> On Oct 13, 2015, at 5:28 PM, Ed Maste wrote:
>
> emaste added a comment.
>
>> Can we get this fixed or reversed out? Thanks!
>
>
> It's already reverted.
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D13482
>
>
>
_
tfiala added a subscriber: tfiala.
tfiala added a comment.
This change appears to have broken quite a few builders.
Can we get this fixed or reversed out? Thanks!
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_build/7935/
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmak
tfiala added a comment.
Oh no worries, just wanted to make sure wasn't missed, that's all.
-Todd
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
.@gmail.com;
> jonat...@codesourcery.com
> Cc: ema...@freebsd.org; Bedwell, Greg; pierregoussea...@gmail.com;
> an...@korobeynikov.info; geek4ci...@gmail.com; cfe-
> comm...@lists.llvm.org; chisophu...@gmail.com
> Subject: Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain
>
emaste added a comment.
> Can we get this fixed or reversed out? Thanks!
It's already reverted.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
emaste added a subscriber: emaste.
Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:4080
@@ +4079,3 @@
+ SmallString<512> PS4SDKDir;
+ if (const char *EnvValue = getenv("SCE_PS4_SDK_DIR"))
+if (!llvm::sys::fs::exists(EnvValue))
Looks like a missing { here
R
ca...@gmail.com;
> jonat...@codesourcery.com
> Cc: Bedwell, Greg; pierregoussea...@gmail.com;
> an...@korobeynikov.info; geek4ci...@gmail.com; cfe-
> comm...@lists.llvm.org; chisophu...@gmail.com
> Subject: Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain
>
> jroelofs accept
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250252: This patch adds missing pieces to clang, including
the PS4 toolchain (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D13482?vs=37292&id=37301#toc
Repository:
rL LLVM
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
One small suggestion. Otherwise, this still LGTM.
Comment at: lib/Driver/ToolChains.cpp:4078
@@ +4077,3 @@
+ // should be /host_tools/bin.
+ const char *EnvValue = getenv("SCE_PS4_S
kromanova updated this revision to Diff 37292.
kromanova added a comment.
Updated the patch based on Jonathan's comments.
Jonathan, if you have a minute, please review.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/B
kromanova added a comment.
Thank you! I will rebase and commit shortly
Katya.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a subscriber: echristo.
echristo added a comment.
(Jonathan's review here is fine, don't wait on me. Thanks! :)
-eric
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
(Jonathan's review here is fine, don't wait on me. Thanks! :)
-eric
On Tue, Oct 13, 2015 at 10:32 AM Jonathan Roelofs
wrote:
> jroelofs added a comment.
>
> Other than that, LGTM too.
>
>
>
> Comment at: lib/Driver/ToolChains.cpp:4081
> @@ +4080,3 @@
> +
> + std::string PS4SDK
jroelofs added a comment.
Other than that, LGTM too.
Comment at: lib/Driver/ToolChains.cpp:4081
@@ +4080,3 @@
+
+ std::string PS4SDKDir = (EnvValue ? EnvValue : getDriver().Dir + "/../..");
+
Use `llvm::sys::path::append` instead of `std::string::operator+` for
filcab accepted this revision.
filcab added a comment.
This revision is now accepted and ready to land.
LGTM. But let's wait for a !Sony dev to say something too.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe
kromanova updated this revision to Diff 36829.
kromanova added a comment.
Few more changes:
(1) There was a bug, where the PS4 driver didn't add input filename in the call
to external assembler.
Filipe fixed this problem in Tools.cpp
(2) A new testcase no-integrated-as.s was added for testing
kromanova added a comment.
Hi Pierre,
I noticed the same issue. When I downloaded a patch from
http://reviews.llvm.org/D11279, I had to manually add .keep files to make tests
to pass.
It's a Phabricator problem. The diff file that I uploaded to Phabricator
contains .keep files, however the di
pgousseau added a comment.
For some reasons the patch file I get from the "download raw diff link" does
not contain the diff for the added .keep files? But the .keep files show up in
phabricator, so I guess it is a phabricator issue?
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
31 matches
Mail list logo
