Beyond that it may be useful to look at who's been contributing to the
code you're trying to change and consider cc'ing them on the review.
(if they can't help, maybe they can point you to someone who can)
On Fri, May 27, 2022 at 2:23 PM stryku_t via cfe-commits
wrote:
>
> Hi Paul,
>
> Thank you
Hi Paul,
Thank you for the tips.
Pinging is indeed mentioned in the docs, but I didn't want to piss everyone
off, so after two pings I thought that I'm doing something wrong. From now
on I'll ping once a week in such situations.
Got review comments now, so we're back on track. Gonna implement
Hi Mateusz,
I wouldn’t worry too much about the failed build. I took a peek and it looks
like the failures are mostly in places very unrelated to your patch. If your
own testing shows no problems, it’s very likely you’re fine.
Regarding lack of response, this is unfortunately more common
