RE: r293457 - Tidy up codegen modules test & make it x86 specific since it relies on Itanium name manglings

2017-01-30 Thread Robinson, Paul via cfe-commits
Okay as is, then. Thanks for the explanation. --paulr From: David Blaikie [mailto:dblai...@gmail.com] Sent: Monday, January 30, 2017 9:32 AM To: Robinson, Paul Cc: cfe-commits (cfe-commits@lists.llvm.org) Subject: Re: r293457 - Tidy up codegen modules test & make it x86 specific since it relies

Re: r293457 - Tidy up codegen modules test & make it x86 specific since it relies on Itanium name manglings

2017-01-30 Thread David Blaikie via cfe-commits
On reflection itanium wouldn't be sufficient/my comment wasn't sufficiently descriptive (I realized after I made this change that it would also fix the MacOS buildbot failure I was seeing & hadn't understood) - Darwin doesn't use comdats, for example, but is still an itanium ABI. I could remove

RE: r293457 - Tidy up codegen modules test & make it x86 specific since it relies on Itanium name manglings

2017-01-30 Thread Robinson, Paul via cfe-commits
Use %itanium_abi_triple instead? > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > David Blaikie via cfe-commits > Sent: Sunday, January 29, 2017 9:34 PM > To: cfe-commits@lists.llvm.org > Subject: r293457 - Tidy up codegen modules test &