Was this reviewed somewhere?
Please make it so that this emits a warning. We want clang-cl to warn on
invalid code (and in system headers warnings are suppressed).
On Wed, May 24, 2017 at 3:31 PM, Erich Keane via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: erichkeane
> Date: Wed M
Reviewed here: https://reviews.llvm.org/D33505
Still, please make this warn.
On Wed, May 24, 2017 at 3:42 PM, Nico Weber wrote:
> Was this reviewed somewhere?
>
> Please make it so that this emits a warning. We want clang-cl to warn on
> invalid code (and in system headers warnings are suppress
Adding Melanie, the author of the patch.
From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber
Sent: Wednesday, May 24, 2017 12:43 PM
To: Keane, Erich
Cc: cfe-commits ; rnk
Subject: Re: r303798 - For Microsoft compatibility, set fno_operator_names
Reviewed here: https
Thanks for the feedback, working on it…
From: Keane, Erich
Sent: Wednesday, May 24, 2017 3:47 PM
To: Nico Weber ; Blower, Melanie
Cc: cfe-commits ; rnk
Subject: RE: r303798 - For Microsoft compatibility, set fno_operator_names
Adding Melanie, the author of the patch.
From: tha...@google.com
2017 4:01 PM, "Blower, Melanie" wrote:
Thanks for the feedback, working on it…
*From:* Keane, Erich
*Sent:* Wednesday, May 24, 2017 3:47 PM
*To:* Nico Weber ; Blower, Melanie <
melanie.blo...@intel.com>
*Cc:* cfe-commits ; rnk
*Subject:* RE: r303798 - For Microsoft compatibility
mailto:tha...@chromium.org>>; Blower,
Melanie mailto:melanie.blo...@intel.com>>
Cc: cfe-commits
mailto:cfe-commits@lists.llvm.org>>; rnk
mailto:r...@chromium.org>>
Subject: RE: r303798 - For Microsoft compatibility, set fno_operator_names
Adding Melanie, the author of th
mailto:tha...@chromium.org>>; Blower,
Melanie mailto:melanie.blo...@intel.com>>
Cc: cfe-commits
mailto:cfe-commits@lists.llvm.org>>; rnk
mailto:r...@chromium.org>>
Subject: RE: r303798 - For Microsoft compatibility, set fno_operator_names
Adding Melanie, the author of the patch.
From
ne, Erich ;
> cfe-commits ; Hans Wennborg >
>
> *Subject:* RE: r303798 - For Microsoft compatibility, set
> fno_operator_names
>
>
>
> In addition to this making clang-cl silently accept invalid code, it also
> breaks existing valid code, building chromium now fail
: Thursday, May 25, 2017 12:56 PM
To: Keane, Erich
Cc: Blower, Melanie ; rnk ;
cfe-commits ; Hans Wennborg
Subject: Re: r303798 - For Microsoft compatibility, set fno_operator_names
On Thu, May 25, 2017 at 12:18 PM, Keane, Erich
mailto:erich.ke...@intel.com>> wrote:
How does chromium co
: Nico Weber [mailto:tha...@google.com]
Sent: Thursday, May 25, 2017 9:56 AM
To: Keane, Erich
Cc: Blower, Melanie ; rnk ;
cfe-commits ; Hans Wennborg
Subject: Re: r303798 - For Microsoft compatibility, set fno_operator_names
On Thu, May 25, 2017 at 12:18 PM, Keane, Erich
mailto:erich.ke...@intel.com
9:56 AM
> *To:* Keane, Erich
> *Cc:* Blower, Melanie ; rnk ;
> cfe-commits ; Hans Wennborg >
>
> *Subject:* Re: r303798 - For Microsoft compatibility, set
> fno_operator_names
>
>
>
> On Thu, May 25, 2017 at 12:18 PM, Keane, Erich
> wrote:
>
> How does
oughts?
>>
>>
>>
>>
>>
>> *From:* Nico Weber [mailto:tha...@google.com]
>> *Sent:* Thursday, May 25, 2017 9:56 AM
>> *To:* Keane, Erich
>> *Cc:* Blower, Melanie ; rnk ;
>> cfe-commits ; Hans Wennborg <
>> h...@chromium.org>
&g
12 matches
Mail list logo
