Re: r316518 - mplement __has_unique_object_representations

2017-10-24 Thread David Majnemer via cfe-commits
On Tue, Oct 24, 2017 at 2:31 PM, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Tue Oct 24 14:31:50 2017 > New Revision: 316518 > > URL: http://llvm.org/viewvc/llvm-project?rev=316518&view=rev > Log: > mplement __has_unique_object_representations > >

RE: r316518 - mplement __has_unique_object_representations

2017-10-24 Thread Keane, Erich via cfe-commits
Yikes! Thanks for pointing this out, fixing it now. From: David Majnemer [mailto:david.majne...@gmail.com] Sent: Tuesday, October 24, 2017 2:55 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r316518 - mplement __has_unique_object_representations On Tue, Oct 24, 2017 at 2:31 PM, Erich

Re: r316518 - mplement __has_unique_object_representations

2017-10-26 Thread Richard Smith via cfe-commits
On 24 Oct 2017 14:32, "Erich Keane via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: erichkeane Date: Tue Oct 24 14:31:50 2017 New Revision: 316518 URL: http://llvm.org/viewvc/llvm-project?rev=316518&view=rev Log: mplement __has_unique_object_representations A helper builtin to facil

RE: r316518 - mplement __has_unique_object_representations

2017-10-26 Thread Keane, Erich via cfe-commits
Thanks for the review Richard. Would you like me to revert, or can I just make these changes in a new patch? From: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Thursday, October 26, 2017 9:50 AM To: Keane, Erich Cc: cfe-commits Subject: Re: r316518 - mplement

RE: r316518 - mplement __has_unique_object_representations

2017-10-26 Thread Richard Smith via cfe-commits
foo.co.uk] *Sent:* Thursday, October 26, 2017 9:50 AM *To:* Keane, Erich *Cc:* cfe-commits *Subject:* Re: r316518 - mplement __has_unique_object_representations On 24 Oct 2017 14:32, "Erich Keane via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: erichkeane Da