RE: r332470 - Add support for __declspec(code_seg("segname"))

2018-05-18 Thread Keane, Erich via cfe-commits
: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Friday, May 18, 2018 1:14 PM To: Keane, Erich <erich.ke...@intel.com> Cc: cfe-commits <cfe-commits@lists.llvm.org> Subject: Re: r332470 - Add support for __declspec(code_seg("segname")) Here's an example regression: https:

Re: r332470 - Add support for __declspec(code_seg("segname"))

2018-05-18 Thread Richard Smith via cfe-commits
Here's an example regression: https://godbolt.org/g/S72Nki I'll check that into the test suite alongside the revert once my testing finishes. On 18 May 2018 at 13:03, Richard Smith wrote: > On 16 May 2018 at 06:57, Erich Keane via cfe-commits < >

Re: r332470 - Add support for __declspec(code_seg("segname"))

2018-05-18 Thread Richard Smith via cfe-commits
On 16 May 2018 at 06:57, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Wed May 16 06:57:17 2018 > New Revision: 332470 > > URL: http://llvm.org/viewvc/llvm-project?rev=332470=rev > Log: > Add support for __declspec(code_seg("segname")) > > Add