Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

2019-01-18 Thread Jordan Rupprecht via cfe-commits
>> *Sent:* Friday, January 18, 2019 9:30 AM >> *To:* Topper, Craig >> *Cc:* cfe-commits@lists.llvm.org >> *Subject:* Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on >> non-windows platforms" >> >> >> >> Hi Craig, >

Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

2019-01-18 Thread Jordan Rupprecht via cfe-commits
what Benjamin Kramer reported on V8? > > > > *From:* Jordan Rupprecht [mailto:ruppre...@google.com] > *Sent:* Friday, January 18, 2019 9:30 AM > *To:* Topper, Craig > *Cc:* cfe-commits@lists.llvm.org > *Subject:* Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_x

RE: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

2019-01-18 Thread Topper, Craig via cfe-commits
what Benjamin Kramer reported on V8? From: Jordan Rupprecht [mailto:ruppre...@google.com] Sent: Friday, January 18, 2019 9:30 AM To: Topper, Craig Cc: cfe-commits@lists.llvm.org Subject: Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms" Hi Craig, We

Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

2019-01-18 Thread Jordan Rupprecht via cfe-commits
Hi Craig, We're seeing issues building a few other things now; notably this part in opencv: https://github.com/opencv/opencv/blob/master/modules/core/src/system.cpp#L422 #ifdef _XCR_XFEATURE_ENABLED_MASK // requires immintrin.h xcr0 = (int)_xgetbv(_XCR_XFEATURE_ENABLED_M