Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread Chris Bieneman via cfe-commits
Hey Richard, This change is tripping up a bunch of the bots: http://lab.llvm.org:8011/builders/clang-cmake-armv8-lld/builds/1397 I'm going to revert it so that we don't leave the bots broken overnight. -Chris > On May 16, 2019, at 6:46 PM, Richard Smith via cfe-commits > wrote: > > Author:

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread Chris Bieneman via cfe-commits
Sorry to do this, but I'm also reverting r360977, because it seems to be on top of this one. -Chris > On May 16, 2019, at 9:58 PM, Chris Bieneman via cfe-commits > wrote: > > Hey Richard, > > This change is tripping up a bunch of the bots: > > http://lab.llvm.org:8011/builders/clang-cmake-a

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread Chris Bieneman via cfe-commits
I did some digging before reverting. The bots your patch is failing on are 32-bit CPUs. It looks like your static_assert is assuming 8-byte aligned pointers, so it always fails on the 32-bit builders. -Chris > On May 16, 2019, at 10:14 PM, Chris Bieneman wrote: > > Sorry to do this, but I'm a

RE: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread via cfe-commits
; cfe-commits@lists.llvm.org Subject: Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info I did some digging before reverting. The bots your patch is failing on are 32-bit CPUs. It looks like your static_assert is assuming 8-byte aligned pointers, so it always fai

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread Richard Smith via cfe-commits
has a 64-bit CPU. > > Douglas Yung > > -Original Message- > From: cfe-commits On Behalf Of Chris > Bieneman via cfe-commits > Sent: Thursday, May 16, 2019 22:45 > To: Chris Bieneman > Cc: Richard Smith ; cfe-commits@lists.llvm.org > Subject: Re: r360974 - Refac

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread Kristina Brooks via cfe-commits
22:45 > To: Chris Bieneman > Cc: Richard Smith ; cfe-commits@lists.llvm.org > Subject: Re: r360974 - Refactor constant evaluation of typeid(T) to track > a symbolic type_info > > I did some digging before reverting. The bots your patch is failing on are > 32-bit CPUs. It loo