Pushed this in LLVM r253511 and clang 253512.
Thanks again for the review Hal.
BTW, I realized the docs need to be updated. I’ll let the bots run on this for
a while and if it all goes well I’ll commit the docs update.
Cheers,
Pete
> On Nov 11, 2015, at 11:25 AM, Pete Cooper via cfe-commits
>
> On Nov 11, 2015, at 11:16 AM, Hal Finkel wrote:
>
> It seems like I dropped the ball on this. Yes, I recall being fine with them
> otherwise.
Thanks Hal! I’ll rebase the patches and land them over the next day or two.
Thanks,
Pete
>
> Thanks again,
> Hal
__
- Original Message -
> From: "Pete Cooper"
> To: "Hal Finkel"
> Cc: "Lang Hames" , "LLVM Commits"
> , cfe-commits@lists.llvm.org
> Sent: Monday, September 28, 2015 12:46:36 PM
> Subject: Re: [PATCH] Change memcpy/memmove/memse
Hey Hal
Thanks for the review. I really appreciate it given the scale of this.
> On Sep 25, 2015, at 1:13 PM, Hal Finkel wrote:
>
> Hi Pete,
>
> Thanks for working on this.
>
> + class IntegerAlignment {
> + private:
> +uint64_t Align;
>
> You explain in the patch summary why this is he
Hi Pete,
Thanks for working on this.
+ class IntegerAlignment {
+ private:
+uint64_t Align;
You explain in the patch summary why this is here, but please add a comment
with the explanation as well.
Regarding the auto-upgrade, are we going to run into problems if we separate
our the 'vol
