This revision was automatically updated to reflect the committed changes.
Closed by commit rL254596: PR25575: Make GCC 4.4+ comatible layout for packed
bit-fileds of char type… (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D14872?vs=41648&id=41724#toc
Repository:
rL
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Thank you!
http://reviews.llvm.org/D14872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
rjmccall added a comment.
LGTM, thanks!
http://reviews.llvm.org/D14872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin updated this revision to Diff 41648.
DmitryPolukhin marked 2 inline comments as done.
DmitryPolukhin added a comment.
Fixed warning and comment.
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/struct-packe
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2788
@@ +2787,3 @@
+def warn_attribute_packed_for_bitfield : Warning<
+ "'packed' attribute was ignored on bit-fields with alignment 1 "
+ "in older versions of GCC and Clang">,
-
DmitryPolukhin updated this revision to Diff 41597.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
Warning text updated, PTAL.
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/struct-pack
rjmccall added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2790
@@ -2790,1 +2789,3 @@
+ "version 4.4 - the newer offset is used here">,
+ InGroup>;
def warn_transparent_union_attribute_field_size_align : Warning<
No, this diagnostic
DmitryPolukhin updated this revision to Diff 41510.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
Don't call getDeclName() that it is not required. PTAL
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:1046
@@ +1045,3 @@
+ diag::note_attribute_packed_for_bitfield_offset_changed)
+<< FD->getDeclName();
+
No need to call getDeclName(), the diagnostic can accept a NamedDe
DmitryPolukhin added a comment.
This is another GCC ABI compatibility issue. If there is no more comments,
could someone please approve this CL?
http://reviews.llvm.org/D14872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
DmitryPolukhin updated this revision to Diff 41222.
DmitryPolukhin marked 2 inline comments as done.
DmitryPolukhin added a comment.
Changed note text message + fixed outdated comment.
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
On Nov 25, 2015 1:53 PM, "hfin...@anl.gov via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> hfinkel added inline comments.
>
>
> Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2783
> @@ -2783,1 +2782,3 @@
> + "the newer semantic is provided here">,
> + InGroup>;
>
hfinkel added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2783
@@ -2783,1 +2782,3 @@
+ "the newer semantic is provided here">,
+ InGroup>;
def warn_transparent_union_attribute_field_size_align : Warning<
Calling this "a semantic" rea
DmitryPolukhin updated this revision to Diff 41131.
DmitryPolukhin added a comment.
Added warning about semantic change + uploaded context. PTAL
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/struct-packed-align.c
Inde
hfinkel added a subscriber: hfinkel.
hfinkel added a comment.
Please upload this patch with full context, see:
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
> Should we add warning about changes in layout for packed bit-fileds of char
> type? GCC has it "note:
DmitryPolukhin added a comment.
It seems that check for type alignment <= 8 was there practically forever
http://llvm.org/viewvc/llvm-project/cfe/trunk/Sema/SemaDecl.cpp?r1=47197&r2=47196&pathrev=47197
and there is no good explanation why it was implemented. Subsequent changes
only add more con
16 matches
Mail list logo
