Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-17 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Removing from my dashboard until http://reviews.llvm.org/D20428 is submitted. Repository: rL LLVM http://reviews.llvm.org/D19201 ___

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Stanisław Barzowski via cfe-commits
sbarzowski marked 11 inline comments as done. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:33 @@ +32,3 @@ +// token including trailing whitespace. +static SourceRange findToken(const SourceManager &Sources, LangOptions LangOpts, + SourceLocat

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 @@ +24,3 @@ + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .bind("throw"), aaron.ballman wrote: > Prazek wrote

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Stanisław Barzowski via cfe-commits
sbarzowski updated this revision to Diff 59277. sbarzowski added a comment. Thanks for review, guys. I fixed as many easy problems as I had time for today, will continue later. Repository: rL LLVM http://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscT

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Aaron Ballman via cfe-commits
aaron.ballman requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 @@ +24,3 @@ + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:32 @@ +31,3 @@ +// token including trailing whitespace. +static SourceRange FindToken(const SourceManager &Sources, LangOptions LangOpts, + SourceLocation StartLoc, So

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 @@ +24,3 @@ + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .bind("throw"), you can use forFunction instead of

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. In http://reviews.llvm.org/D19201#445496, @aaron.ballman wrote: > In http://reviews.llvm.org/D19201#445406, @sbarzowski wrote: > > > Note ``FunctionProtoType::getNoExceptExpr`` is weird. If you have the same > > expr in multiple noexcepts, then it returns the same object

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In http://reviews.llvm.org/D19201#445406, @sbarzowski wrote: > Note ``FunctionProtoType::getNoExceptExpr`` is weird. If you have the same > expr in multiple noexcepts, t

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Stanisław Barzowski via cfe-commits
sbarzowski added a comment. Note ``FunctionProtoType::getNoExceptExpr`` is weird. If you have the same expr in multiple noexcepts, then it returns the same object for all of them, so it is useless for determining the location in code. I ended up finding it all "by hand" with lexer (looking for

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Stanisław Barzowski via cfe-commits
sbarzowski updated the summary for this revision. sbarzowski removed rL LLVM as the repository for this revision. sbarzowski updated this revision to Diff 59179. http://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/ThrowWith

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-04-22 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Please fix formatting, btw. Repository: rL LLVM http://reviews.llvm.org/D19201 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-04-21 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D19201#403585, @Prazek wrote: > Do you know guys is it possible to get to noexcept source location, or we > have to do by hand using lexer? If it might be possible to get the location of `noexcept(expression)` using `FunctionProtoType::getNoE