teemperor updated this revision to Diff 55716.
teemperor added a comment.
Merged all tests into one file.
http://reviews.llvm.org/D19312
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/warn-undefined-in-ctor
teemperor updated this revision to Diff 55245.
teemperor added a comment.
- Added checks and tests for typeid
- Moved warnings into same warning group
- Check that only possibly evaluated expressions are checked
http://reviews.llvm.org/D19312
Files:
include/clang/Basic/DiagnosticGroups.td
i
teemperor updated this revision to Diff 55189.
teemperor added a comment.
- Moved checks to the UninitializedFieldVisitor
- Also check for dynamic_cast on this during construction
http://reviews.llvm.org/D19312
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclCXX.cpp
tes
teemperor marked 4 inline comments as done.
teemperor added a comment.
No, didn't saw the thread so far. I assume the comments in there are still
valid, so I'll update this patch.
Thanks for the feedback so far!
http://reviews.llvm.org/D19312
___
c
rtrieu added a subscriber: rtrieu.
rtrieu added a comment.
Have you looked at http://reviews.llvm.org/D6561 which was a previous attempt
at this warning?
http://reviews.llvm.org/D19312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
filcab added a comment.
The patch needs to get through clang-format.
Should we deal with typeid and dynamic_cast, since they're mentioned in the
same paragraph in the standard?
Comment at: lib/Sema/SemaDeclCXX.cpp:3895
@@ +3894,3 @@
+ // Check if member call is actually to
teemperor updated this revision to Diff 54464.
teemperor added a comment.
- Standard reference is now specifying what standard (C++11)
- Added test based on the standard example
- Also check base classes now for member calls (to pass the test from the
standard example).
http://reviews.llvm.org/
teemperor added a comment.
Oh, totally forgot that I also had a reference in the code, thanks! Will fix it
ASAP.
Adding the example from the standard to the test cases sounds good. It actually
tests a few things that aren't covered by the current test.
http://reviews.llvm.org/D19312
__
filcab added a comment.
I meant changing the diff, but if you prefer to have a smaller comment, I'm ok
with the different "paths" in the standards being mentioned only in the commit
message.
Comment at: lib/Sema/SemaDeclCXX.cpp:3941
@@ +3940,3 @@
+ // Calling a member fun
filcab added a subscriber: filcab.
filcab added a comment.
You might want to mention that it's 12.6.2p16 in C++14/17 but p13 in C++11.
I wonder if we should have the example in the standard, verbatim. (Plus the
added tests you made)
http://reviews.llvm.org/D19312
teemperor updated this revision to Diff 54343.
teemperor added a comment.
- Fixed indentation
http://reviews.llvm.org/D19312
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/ctor-init-with-member-call.cpp
Index: test/SemaCXX/ctor-init-with-member-ca
11 matches
Mail list logo