Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

2016-06-15 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. lgtm Surely this is going to break something, but let's throw the switch and find out. http://reviews.llvm.org/D20347 ___ cfe-commits mailing list

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

2016-06-09 Thread Nico Weber via cfe-commits
thakis added a comment. probably at least the "the XOR with RSP/EBP/ESP" bit still (and maybe EH function upgrades instead of bailing) Comment at: lib/Driver/Tools.cpp:9990 @@ +9989,3 @@ + /*default=*/false)) +CmdArgs.push_back("/GS-"); +

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

2016-06-09 Thread Hans Wennborg via cfe-commits
hans added a comment. Is this waiting for anything more now that http://reviews.llvm.org/D20346 has landed? http://reviews.llvm.org/D20347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

2016-05-25 Thread Etienne Bergeron via cfe-commits
etienneb added a comment. This patch needs land after http://reviews.llvm.org/D20346. thx for the review. http://reviews.llvm.org/D20347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

2016-05-25 Thread Etienne Bergeron via cfe-commits
etienneb updated this revision to Diff 58502. etienneb marked an inline comment as done. etienneb added a comment. more tests http://reviews.llvm.org/D20347 Files: include/clang/Driver/CLCompatOptions.td lib/Driver/Tools.cpp test/Driver/cl-fallback.c test/Driver/cl-options.c Index: