This revision was automatically updated to reflect the committed changes.
omtcyfz marked an inline comment as done.
Closed by commit rL278760: [clang-rename] cleanup `auto` usages (authored by
omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23397?vs=68104&id=68107#toc
Repository:
omtcyfz marked 2 inline comments as done.
Comment at: clang-rename/USRFinder.cpp:182-184
@@ -179,6 +181,5 @@
// We only want to search the decls that exist in the same file as the point.
- auto Decls = Context.getTranslationUnitDecl()->decls();
- for (auto &CurrDecl : Decls)
omtcyfz updated this revision to Diff 68104.
omtcyfz added a comment.
Address comments.
https://reviews.llvm.org/D23397
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFindingAction.cpp
clang-rename/USRLocFinder.cpp
Index: clang-rename/USRLocFinder.cpp
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a couple of nits.
Comment at: clang-rename/USRFinder.cpp:182
@@ -179,5 +181,3 @@
// We only want to search the decls that exist in the same file as the point.
- au
omtcyfz updated this revision to Diff 67989.
omtcyfz marked 3 inline comments as done.
omtcyfz added a comment.
Address comments.
https://reviews.llvm.org/D23397
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFindingAction.cpp
clang-rename/USRLocFinder
alexfh added a comment.
A couple of comments inline.
Comment at: clang-rename/RenamingAction.cpp:73
@@ -72,3 +72,3 @@
// FIXME: better error handling.
- auto Replace = tooling::Replacement(SourceMgr, Loc, PrevNameLen,
NewName);
- auto Err = FileToReplaces[Repla
