Re: [PATCH] D27597: [DebugInfo] Restore test case for long double constants.

2016-12-12 Thread David Blaikie via cfe-commits
On Mon, Dec 12, 2016 at 1:11 PM David Gross wrote: > I looked at what's supported by "requires", and couldn't find anything > appropriate. > > The problem is that I want the test to be sensitive to the size of long > double -- either no greater than 64 bits, or greater than 64 bits. It does > no

Re: [PATCH] D27597: [DebugInfo] Restore test case for long double constants.

2016-12-12 Thread David Gross via cfe-commits
I looked at what's supported by "requires", and couldn't find anything appropriate. The problem is that I want the test to be sensitive to the size of long double -- either no greater than 64 bits, or greater than 64 bits. It does not seem practical to list all platforms (so I suspect your "xfail

Re: [PATCH] D27597: [DebugInfo] Restore test case for long double constants.

2016-12-12 Thread David Blaikie via cfe-commits
While it's possible to do arbitrary script things - we prefer nto to to ensure the tests are portable. (we have some custom implementations of common unix utilities for portability of those). In this case, can you xfail this on platforms that don't have the feature you want? rather than trying to