This revision was automatically updated to reflect the committed changes.
Closed by commit rL277095: [Parser] Fix bug where delayed typo in conditional
expression was corrected… (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D22930?vs=65965&id=66067#toc
Repository:
rL
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D22930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
dtarditi created this revision.
dtarditi added a reviewer: erik.pilkington.
dtarditi added a subscriber: cfe-commits.
r272587 (http://reviews.llvm.org/D20490) fixed an issue where typo correction
could cause a crash when compiling C programs.The problem was that a typo
expression could be in
Thanks for taking a look at this!
I have two comments:
1. If we’re doing the check at the end of both branches of the if, we might as
well just move it to after.
2. It doesn’t make sense to have a failure that only occurs in C mode in
test/SemaCXX. Maybe just append it to the end of test/Sema/
r272587 (http://reviews.llvm.org/D20490) fixed an issue where typo correction
could cause a crash when compiling C programs.The problem was that a typo
expression could be inadvertently processed twice.r272587 fixed this for
BinOp expressions. Conditional expressions can hit the same p
