I've reverted r245456 in r245623.
Thanks,
Hans
On Thu, Aug 20, 2015 at 2:56 PM, Richard Smith rich...@metafoo.co.uk wrote:
The cumulative effect of all the patches so far has been to revert this
change from trunk. Hans, can you revert it on the branch too?
Thanks.
On Wed, Aug 19, 2015 at
Sorry to notice late (just diagnosed the issue from a failing boost::math
test), according to i686 ABI, long double size on x86 is 12 bytes (the
memory allocated, not the underlying 80 bits register), see
https://gcc.gnu.org/onlinedocs/gcc-3.2/gcc/i386-and-x86-64-Options.html
I assume this is a merge request?
Richard: what do you think about r245459+r245462?
On Wed, Aug 19, 2015 at 10:22 AM, Yaron Keren yaron.ke...@gmail.com wrote:
Sorry to notice late (just diagnosed the issue from a failing boost::math
test), according to i686 ABI, long double size on x86 is 12
Thanks for the spot yaron.
I had only tested x64 at the time as that's what the original bug report
was for.
I can confirm that your fix does infact fix i686
Many Thanks
Martell
On Wed, Aug 19, 2015 at 1:22 PM, Yaron Keren yaron.ke...@gmail.com wrote:
Yes, worth merging with Richard approval.
On Tue, Aug 18, 2015 at 3:01 PM, Hans Wennborg h...@chromium.org wrote:
Richard, I tried to ping you on the review thread but I'm not sure it
got through. Martell requested this be merged to 3.7. What do you
think?
LGTM
On Fri, Aug 14, 2015 at 12:05 PM, Martell Malone via cfe-commits
