Re: r245352 - Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor.

2015-08-18 Thread David Blaikie via cfe-commits
On Tue, Aug 18, 2015 at 4:46 PM, Richard Smith wrote: > On Tue, Aug 18, 2015 at 2:03 PM, David Blaikie wrote: > >> Richard, do you think there's anything we could do better here? >> >> It seems difficult to support proper move semantic behavior for >> [Sema]DiagnosticBuilder across the two commo

Re: r245352 - Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor.

2015-08-18 Thread Richard Smith via cfe-commits
On Tue, Aug 18, 2015 at 2:03 PM, David Blaikie wrote: > Richard, do you think there's anything we could do better here? > > It seems difficult to support proper move semantic behavior for > [Sema]DiagnosticBuilder across the two common use cases: > > DiagnosticBuilder D; > D << x; > D << y;

Re: r245352 - Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor.

2015-08-18 Thread David Blaikie via cfe-commits
Richard, do you think there's anything we could do better here? It seems difficult to support proper move semantic behavior for [Sema]DiagnosticBuilder across the two common use cases: DiagnosticBuilder D; D << x; D << y; return D; and return DiagnosticBuilder() << x << y; The only t

r245352 - Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor.

2015-08-18 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Tue Aug 18 15:54:26 2015 New Revision: 245352 URL: http://llvm.org/viewvc/llvm-project?rev=245352&view=rev Log: Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor. Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Se