Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

Thanks, I have replied there. 2015-09-19 13:33 GMT+03:00 Hal Finkel : > FYI: https://llvm.org/bugs/show_bug.cgi?id=24398 was just reopened > pointing to a lack of resolution here. > > -Hal > > - Original Message - > > From: "Yaron Keren via cfe-commits"

r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

For reference It was raised again here also https://github.com/Alexpux/MINGW-packages/issues/722 "that is extended from X86TargetInfo Which sets LongDoubleFormat = ::APFloat::x87DoubleExtended;" On Saturday, September

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

FYI: https://llvm.org/bugs/show_bug.cgi?id=24398 was just reopened pointing to a lack of resolution here. -Hal - Original Message - > From: "Yaron Keren via cfe-commits" > To: "Martell Malone" > Cc: "Richard Smith"

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

I can't reproduce sizeof = 12 when targetting 64 bits, it is 16 (LongDoubleWidth = 128) and have been this way since r55036. It may be that both 32 bit mingw and 64 bit mingw are installed and clang is targetting the 32 bits while gcc targets 64 bits. 2015-09-19 15:24 GMT+03:00 Martell Malone

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

The testcase from r245459 was not reverted and still in SVN. 2015-08-21 2:05 GMT+03:00 Martell Malone martellmal...@gmail.com: I feel very silly now. After testing the testcase again on svn it still works. It appears the OP was looking for this patch to go onto the 3.6 branch and was

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

I feel very silly now. After testing the testcase again on svn it still works. It appears the OP was looking for this patch to go onto the 3.6 branch and was applying my patch to that. I'll know in future to recheck the testcase afterwards myself in future. Apologies for the noise guys. Yaron I

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

On Wed, Aug 19, 2015 at 11:42 AM, Yaron Keren yaron.ke...@gmail.com wrote: Yes, it looks like a legacy issue. Documentation says so: *https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html*

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

OK, so here's the problem: The right way to fix this seems to be to delete the assignments to LongDouble* from the MinGWX86_32TargetInfo constructor; the X86_32TargetInfo and X86TargetInfo base classes already set them to the right values. Likewise we can delete the assignments to LongDouble*

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

Yes, it looks like a legacy issue. Documentation says so: *https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html* -m96bit-long-double-m128bit-long-doubleThese switches control the size of long double