Re: r248904 - clang-format: Use Rewriter again to write the output files.

2015-09-30 Thread Daniel Jasper via cfe-commits
Ah, very sorry, I was looking at the wrong patch. So I did make the same change :-) On Wed, Sep 30, 2015 at 9:30 PM, Daniel Jasper wrote: > cmake build hopefully fixed in r248929. How is the patch you have attached > related? > > On Wed, Sep 30, 2015 at 9:24 PM, Daniel Jasper wrote: > >> This b

Re: r248904 - clang-format: Use Rewriter again to write the output files.

2015-09-30 Thread Daniel Jasper via cfe-commits
cmake build hopefully fixed in r248929. How is the patch you have attached related? On Wed, Sep 30, 2015 at 9:24 PM, Daniel Jasper wrote: > This breaks your *build*? How? > > On Wed, Sep 30, 2015 at 9:19 PM, Jan Vesely > wrote: > >> Hi, >> I think this change breaks cmake build. Please consider

Re: r248904 - clang-format: Use Rewriter again to write the output files.

2015-09-30 Thread Daniel Jasper via cfe-commits
This breaks your *build*? How? On Wed, Sep 30, 2015 at 9:19 PM, Jan Vesely wrote: > Hi, > I think this change breaks cmake build. Please consider the attached fix > (I can't push atm). > > thank you, > Jan > > On Wed, Sep 30, 2015 at 8:59 AM, Daniel Jasper via cfe-commits < > cfe-commits@lists.l

Re: r248904 - clang-format: Use Rewriter again to write the output files.

2015-09-30 Thread Jan Vesely via cfe-commits
Hi, I think this change breaks cmake build. Please consider the attached fix (I can't push atm). thank you, Jan On Wed, Sep 30, 2015 at 8:59 AM, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Wed Sep 30 08:59:29 2015 > New Revision: 248904 > > URL: h

r248904 - clang-format: Use Rewriter again to write the output files.

2015-09-30 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Wed Sep 30 08:59:29 2015 New Revision: 248904 URL: http://llvm.org/viewvc/llvm-project?rev=248904&view=rev Log: clang-format: Use Rewriter again to write the output files. This has two advantages: 1. Atomic writes. 2. Proper handling of line endings (hopefully solving llvm.o