Re: r250473 - Add an error when calling a builtin that requires features that don't

No worries! :) On Sun, Oct 18, 2015, 5:42 PM Justin Bogner wrote: > Eric Christopher writes: > > I'm reasonably certain you forgot to rebuild or ran make test in the > wrong > > directory. > > You're right, I did something funny there. Sorry for the noise. > > > Two reasons: > > > > a) This is

Re: r250473 - Add an error when calling a builtin that requires features that don't

Eric Christopher writes: > I'm reasonably certain you forgot to rebuild or ran make test in the wrong > directory. You're right, I did something funny there. Sorry for the noise. > Two reasons: > > a) This is pretty much my first patch. I mean, identical and I tried that. > b) I actually tried t

Re: r250473 - Add an error when calling a builtin that requires features that don't

On Sat, Oct 17, 2015 at 4:30 AM Dimitry Andric wrote: > On 16 Oct 2015, at 01:47, Eric Christopher via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > Author: echristo > > Date: Thu Oct 15 18:47:11 2015 > > New Revision: 250473 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=25047

Re: r250473 - Add an error when calling a builtin that requires features that don't

On 16 Oct 2015, at 01:47, Eric Christopher via cfe-commits wrote: > > Author: echristo > Date: Thu Oct 15 18:47:11 2015 > New Revision: 250473 > > URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev > Log: > Add an error when calling a builtin that requires features that don't > match

Re: r250473 - Add an error when calling a builtin that requires features that don't

I'm reasonably certain you forgot to rebuild or ran make test in the wrong directory. Two reasons: a) This is pretty much my first patch. I mean, identical and I tried that. b) I actually tried this one and got: Testing Time: 217.41s Failing Tests (68): Clang :: CodeGen/

Re: r250473 - Add an error when calling a builtin that requires features that don't

Eric Christopher writes: > Can't be. We don't know we're going to make the call until we code gen. :) Okay... but then why don't any tests fail with the attached? It looks like it does the right thing in a very cursory test, as well. commit 63d58fd0b4b77c9486901c103ec70c974d0c2553 Author: Justin

Re: r250473 - Add an error when calling a builtin that requires features that don't

Can't be. We don't know we're going to make the call until we code gen. :) On Fri, Oct 16, 2015, 7:50 PM Justin Bogner wrote: > Eric Christopher via cfe-commits writes: > > Author: echristo > > Date: Thu Oct 15 18:47:11 2015 > > New Revision: 250473 > > > > URL: http://llvm.org/viewvc/llvm-proj

Re: r250473 - Add an error when calling a builtin that requires features that don't

Eric Christopher via cfe-commits writes: > Author: echristo > Date: Thu Oct 15 18:47:11 2015 > New Revision: 250473 > > URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev > Log: > Add an error when calling a builtin that requires features that don't > match the feature set of the functio

Re: r250473 - Add an error when calling a builtin that requires features that don't

Woot! Thanks! > On Oct 15, 2015, at 4:47 PM, Eric Christopher via cfe-commits > wrote: > > Author: echristo > Date: Thu Oct 15 18:47:11 2015 > New Revision: 250473 > > URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev > Log: > Add an error when calling a builtin that requires feature

r250473 - Add an error when calling a builtin that requires features that don't

Author: echristo Date: Thu Oct 15 18:47:11 2015 New Revision: 250473 URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev Log: Add an error when calling a builtin that requires features that don't match the feature set of the function that they're being called from. This ensures that we c