Author: rsmith
Date: Wed Nov 4 18:54:55 2015
New Revision: 252114
URL: http://llvm.org/viewvc/llvm-project?rev=252114&view=rev
Log:
[modules] If we're given a module file, via -fmodule-file=, for a module, but
we can't load that file due to a configuration mismatch, and implicit module
building i
FYI I changed this to early-exit again in r260563 to fix implicit builds. It’s
not safe to keep reading if we haven’t told ReadOptionsBlock to expect
failures, since it will itself early-exit, leaving the stream in the middle of
a block. It’s also a performance advantage to early exit when doi
> On Feb 11, 2016, at 11:04 AM, Ben Langmuir wrote:
>
> FYI I changed this to early-exit again in r260563 to fix implicit builds.
> It’s not safe to keep reading if we haven’t told ReadOptionsBlock to expect
> failures, since it will itself early-exit, leaving the stream in the middle
> of a
On Thu, Feb 11, 2016 at 11:04 AM, Ben Langmuir wrote:
> FYI I changed this to early-exit again in r260563 to fix implicit builds.
> It’s not safe to keep reading if we haven’t told ReadOptionsBlock to expect
> failures, since it will itself early-exit, leaving the stream in the middle
> of a block
Hi Richard,
This change
> @@ -2239,16 +2240,21 @@ ASTReader::ReadControlBlock(ModuleFile &F,
[...]
> - if (!DisableValidation && Result != Success &&
> - (Result != ConfigurationMismatch ||
> !AllowConfigurationMismatch))
> + if (DisableValidation ||
> +
> On Jan 8, 2016, at 2:39 PM, Adrian Prantl wrote:
>
> Hi Richard,
>
> This change
>> @@ -2239,16 +2240,21 @@ ASTReader::ReadControlBlock(ModuleFile &F,
> [...]
>> - if (!DisableValidation && Result != Success &&
>> - (Result != ConfigurationMismatch ||
>> !AllowConfigur
