r252474 - Create install targets for scan-build and scan-view

2015-11-09 Thread Jonathan Roelofs via cfe-commits
Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev Log: Create install targets for scan-build and scan-view http://reviews.llvm.org/D14403 Added: cfe/trunk/tools/scan-build/CMakeLists.txt cfe/trunk/tools/scan-

Re: r252474 - Create install targets for scan-build and scan-view

2016-02-11 Thread Hans Wennborg via cfe-commits
On Mon, Nov 9, 2015 at 8:12 AM, Jonathan Roelofs via cfe-commits wrote: > Author: jroelofs > Date: Mon Nov 9 10:12:56 2015 > New Revision: 252474 > > URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev > Log: > Create install targets for scan-build and scan-view > > http://reviews.llvm.o

Re: r252474 - Create install targets for scan-build and scan-view

2016-02-11 Thread Jonathan Roelofs via cfe-commits
On 2/11/16 7:24 PM, Hans Wennborg wrote: On Mon, Nov 9, 2015 at 8:12 AM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev Log: Create install targets for scan-build and sc

Re: r252474 - Create install targets for scan-build and scan-view

2015-11-10 Thread Tobias Grosser via cfe-commits
On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev Log: Create install targets for scan-build and scan-view Hi Jonathan, this is probably not the comm

Re: r252474 - Create install targets for scan-build and scan-view

2015-11-10 Thread Jonathan Roelofs via cfe-commits
On 11/10/15 12:48 PM, Tobias Grosser wrote: On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev Log: Create install targets for scan-build and scan-vie

Re: r252474 - Create install targets for scan-build and scan-view

2015-11-10 Thread Tobias Grosser via cfe-commits
On 11/10/2015 09:05 PM, Jonathan Roelofs wrote: On 11/10/15 12:48 PM, Tobias Grosser wrote: On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev Log: C

Re: r252474 - Create install targets for scan-build and scan-view

2015-11-10 Thread Jonathan Roelofs via cfe-commits
On 11/10/15 1:35 PM, Tobias Grosser wrote: On 11/10/2015 09:05 PM, Jonathan Roelofs wrote: On 11/10/15 12:48 PM, Tobias Grosser wrote: On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/

Re: r252474 - Create install targets for scan-build and scan-view

2015-11-10 Thread Chris Bieneman via cfe-commits
Your custom commands don’t have outputs, so ninja doesn’t know when they need to run or not. -Chris > On Nov 10, 2015, at 2:14 PM, Jonathan Roelofs > wrote: > > > > On 11/10/15 1:35 PM, Tobias Grosser wrote: >> On 11/10/2015 09:05 PM, Jonathan Roelofs wrote: >>> >>> >>> On 11/10/15 12:48

Re: r252474 - Create install targets for scan-build and scan-view

2015-11-10 Thread Jonathan Roelofs via cfe-commits
On 11/10/15 3:18 PM, Chris Bieneman wrote: Your custom commands don’t have outputs, so ninja doesn’t know when they need to run or not. Thanks! -Chris On Nov 10, 2015, at 2:14 PM, Jonathan Roelofs wrote: On 11/10/15 1:35 PM, Tobias Grosser wrote: On 11/10/2015 09:05 PM, Jonathan Ro

Re: r252474 - Create install targets for scan-build and scan-view

2015-11-10 Thread Tobias Grosser via cfe-commits
On 11/10/2015 11:42 PM, Jonathan Roelofs wrote: Fixed for real in r252662. Confirmed. Thank you for addressing this so quickly. Tobias ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: r252474 - Create install targets for scan-build and scan-view

2015-11-11 Thread Aaron Ballman via cfe-commits
This change causes MSVC to have two new projects sitting at the root of the solution: scan-build and scan-view, neither of which appear to do anything. Are these projects required for IDEs? If they're installation-only projects, I think the CMake should be guarded with `if(NOT CMAKE_CONFIGURATION_T

Re: r252474 - Create install targets for scan-build and scan-view

2015-11-11 Thread Jonathan Roelofs via cfe-commits
On 11/11/15 8:07 AM, Aaron Ballman wrote: This change causes MSVC to have two new projects sitting at the root of the solution: scan-build and scan-view, neither of which appear to do anything. Are these projects required for IDEs? If they're installation-only projects, I think the CMake should