Re: r255371 - Error on redeclaring with a conflicting asm label and on redeclaring with an asm label after the first ODR-use. Detects problems like the one in PR22830 where gcc and clang both compiled

2016-01-04 Thread Nick Lewycky via cfe-commits
On 01/04/2016 01:40 PM, Kostya Serebryany wrote: On Thu, Dec 17, 2015 at 5:03 PM, Richard Smith > wrote: On Thu, Dec 17, 2015 at 3:59 PM, Nick Lewycky via cfe-commits >

Re: r255371 - Error on redeclaring with a conflicting asm label and on redeclaring with an asm label after the first ODR-use. Detects problems like the one in PR22830 where gcc and clang both compiled

2016-01-04 Thread Roland McGrath via cfe-commits
Kostya, do you remember the exact original case in glibc for 22830 and what glibc change fixed it? I vaguely recall the case, but not enough to find the actual change and compare it to the new scenarios. I suspect that the original case was easy to fix because it was just that the hidden_proto

Re: r255371 - Error on redeclaring with a conflicting asm label and on redeclaring with an asm label after the first ODR-use. Detects problems like the one in PR22830 where gcc and clang both compiled

2016-01-04 Thread Kostya Serebryany via cfe-commits
Thanks for checking, Nick! +Roland, FYI (recent changes in clang break compilation of all of the glibc), similar to https://llvm.org/bugs/show_bug.cgi?id=22830#c1 On Mon, Jan 4, 2016 at 3:21 PM, Nick Lewycky wrote: > On 01/04/2016 01:40 PM, Kostya Serebryany wrote: > >> >> >>

Re: r255371 - Error on redeclaring with a conflicting asm label and on redeclaring with an asm label after the first ODR-use. Detects problems like the one in PR22830 where gcc and clang both compiled

2015-12-17 Thread Kostya Serebryany via cfe-commits
I am now observing this error message when building glibc with clang (from trunk): ../include/string.h:101:28: error: cannot apply asm label to function after its first use libc_hidden_builtin_proto (memcpy) (many more instances) Do you think this is a bug in glibc code, or the error message

Re: r255371 - Error on redeclaring with a conflicting asm label and on redeclaring with an asm label after the first ODR-use. Detects problems like the one in PR22830 where gcc and clang both compiled

2015-12-17 Thread Nick Lewycky via cfe-commits
On 12/17/2015 10:47 AM, Kostya Serebryany wrote: I am now observing this error message when building glibc with clang (from trunk): ../include/string.h:101:28: error: cannot apply asm label to function after its first use libc_hidden_builtin_proto (memcpy) (many more instances) Do you think

Re: r255371 - Error on redeclaring with a conflicting asm label and on redeclaring with an asm label after the first ODR-use. Detects problems like the one in PR22830 where gcc and clang both compiled

2015-12-17 Thread Richard Smith via cfe-commits
On Thu, Dec 17, 2015 at 3:59 PM, Nick Lewycky via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 12/17/2015 10:47 AM, Kostya Serebryany wrote: > >> I am now observing this error message when building glibc with clang >> (from trunk): >> ../include/string.h:101:28: error: cannot apply asm