Re: r255875 - Add QualType case to operator< for DynTypedNode.

2015-12-17 Thread Aaron Ballman via cfe-commits
On Wed, Dec 16, 2015 at 11:46 PM, Richard Trieu via cfe-commits wrote: > Author: rtrieu > Date: Wed Dec 16 22:46:48 2015 > New Revision: 255875 > > URL: http://llvm.org/viewvc/llvm-project?rev=255875=rev > Log: > Add QualType case to operator< for DynTypedNode. > >

Re: r255875 - Add QualType case to operator< for DynTypedNode.

2015-12-17 Thread Aaron Ballman via cfe-commits
On Thu, Dec 17, 2015 at 5:02 PM, Richard Trieu wrote: > On Thu, Dec 17, 2015 at 5:47 AM, Aaron Ballman > wrote: >> >> On Wed, Dec 16, 2015 at 11:46 PM, Richard Trieu via cfe-commits >> wrote: >> > Author: rtrieu >> > Date:

Re: r255875 - Add QualType case to operator< for DynTypedNode.

2015-12-17 Thread Richard Trieu via cfe-commits
On Thu, Dec 17, 2015 at 5:47 AM, Aaron Ballman wrote: > On Wed, Dec 16, 2015 at 11:46 PM, Richard Trieu via cfe-commits > wrote: > > Author: rtrieu > > Date: Wed Dec 16 22:46:48 2015 > > New Revision: 255875 > > > > URL:

Re: r255875 - Add QualType case to operator< for DynTypedNode.

2015-12-17 Thread Richard Trieu via cfe-commits
The assert was the one later in the function: assert(getMemoizationData() && Other.getMemoizationData()); My best guess as to what happened was my configuration had a container which reordered the comparison, making the QualType comparison happen earlier than it would otherwise. r255937 has a

Re: r255875 - Add QualType case to operator< for DynTypedNode.

2015-12-17 Thread Aaron Ballman via cfe-commits
On Thu, Dec 17, 2015 at 6:25 PM, Richard Trieu wrote: > The assert was the one later in the function: > assert(getMemoizationData() && Other.getMemoizationData()); > My best guess as to what happened was my configuration had a container which > reordered the comparison,

r255875 - Add QualType case to operator< for DynTypedNode.

2015-12-16 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Wed Dec 16 22:46:48 2015 New Revision: 255875 URL: http://llvm.org/viewvc/llvm-project?rev=255875=rev Log: Add QualType case to operator< for DynTypedNode. This allows sorting DynTypedNode's which are QualType's since QualType does not have memoization. Modified: