r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

2016-03-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Mar 7 18:32:55 2016 New Revision: 262881 URL: http://llvm.org/viewvc/llvm-project?rev=262881&view=rev Log: P0188R1: add support for standard [[fallthrough]] attribute. This is almost exactly the same as clang's existing [[clang::fallthrough]] attribute, which has been upd

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

2016-03-08 Thread Nico Weber via cfe-commits
This causes clang to warn on default: assert (false); HB_FALLTHROUGH; The fallthrough needs to be there for release builds, but now it must not be there for debug builds. I suppose this means projects now need an UNREACHED_CASE macro that expands to assert(false) in debug and to fallthrough in

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

2016-03-08 Thread Richard Smith via cfe-commits
On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber wrote: > This causes clang to warn on > > default: assert (false); HB_FALLTHROUGH; What follows this? (A case label?) What warning is being produced? > The fallthrough needs to be there for release builds, but now it must not be > there for debug buil

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

2016-03-08 Thread Nico Weber via cfe-commits
On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith wrote: > On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber wrote: > > This causes clang to warn on > > > > default: assert (false); HB_FALLTHROUGH; > > What follows this? (A case label?) What warning is being produced? > A case label. Full snippet: https

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

2016-03-08 Thread Richard Smith via cfe-commits
On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote: > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith wrote: >> >> On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber wrote: >> > This causes clang to warn on >> > >> > default: assert (false); HB_FALLTHROUGH; >> >> What follows this? (A case label?) What w

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

2016-03-08 Thread Nico Weber via cfe-commits
On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith wrote: > On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote: > > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith > wrote: > >> > >> On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber wrote: > >> > This causes clang to warn on > >> > > >> > default: assert (

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

2016-03-09 Thread Nico Weber via cfe-commits
On Tue, Mar 8, 2016 at 12:18 PM, Nico Weber wrote: > On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith > wrote: > >> On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote: >> > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith >> wrote: >> >> >> >> On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber >> wrote: >>

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

2016-03-10 Thread Nico Weber via cfe-commits
On Wed, Mar 9, 2016 at 6:44 PM, Nico Weber wrote: > On Tue, Mar 8, 2016 at 12:18 PM, Nico Weber wrote: > >> On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith >> wrote: >> >>> On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote: >>> > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith >>> wrote: >>> >> >

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

2016-03-10 Thread Richard Smith via cfe-commits
On Thu, Mar 10, 2016 at 10:47 AM, Nico Weber wrote: > On Wed, Mar 9, 2016 at 6:44 PM, Nico Weber wrote: >> >> On Tue, Mar 8, 2016 at 12:18 PM, Nico Weber wrote: >>> >>> On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith >>> wrote: On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote: >