Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

2016-03-15 Thread Benjamin Kramer via cfe-commits
On Mon, Mar 14, 2016 at 5:50 PM, Richard Smith wrote: > On 14 Mar 2016 6:28 a.m., "Benjamin Kramer via cfe-commits" > wrote: >> >> Author: d0k >> Date: Mon Mar 14 08:23:58 2016 >> New Revision: 263429 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=263429&view=rev >> Log: >> [Frontend] Disable

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

2016-03-14 Thread Alexey Samsonov via cfe-commits
On Mon, Mar 14, 2016 at 8:55 AM, Evgenii Stepanov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Mar 14, 2016 at 8:48 AM, Benjamin Kramer > wrote: > > On Mon, Mar 14, 2016 at 3:59 PM, David Blaikie > wrote: > >> Yeah - how are they relying on them in a non-asserts build anyway? >

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

2016-03-14 Thread Alexey Samsonov via cfe-commits
On Mon, Mar 14, 2016 at 9:50 AM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 14 Mar 2016 6:28 a.m., "Benjamin Kramer via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > > > Author: d0k > > Date: Mon Mar 14 08:23:58 2016 > > New Revision: 263429 > > > > URL: http

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

2016-03-14 Thread Richard Smith via cfe-commits
On 14 Mar 2016 6:28 a.m., "Benjamin Kramer via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > > Author: d0k > Date: Mon Mar 14 08:23:58 2016 > New Revision: 263429 > > URL: http://llvm.org/viewvc/llvm-project?rev=263429&view=rev > Log: > [Frontend] Disable value name discarding for all sanitiz

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

2016-03-14 Thread David Blaikie via cfe-commits
On Mon, Mar 14, 2016 at 8:55 AM, Evgenii Stepanov wrote: > On Mon, Mar 14, 2016 at 8:48 AM, Benjamin Kramer > wrote: > > On Mon, Mar 14, 2016 at 3:59 PM, David Blaikie > wrote: > >> Yeah - how are they relying on them in a non-asserts build anyway? > (were we > >> naming certain things regardle

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

2016-03-14 Thread Evgenii Stepanov via cfe-commits
On Mon, Mar 14, 2016 at 8:48 AM, Benjamin Kramer wrote: > On Mon, Mar 14, 2016 at 3:59 PM, David Blaikie wrote: >> Yeah - how are they relying on them in a non-asserts build anyway? (were we >> naming certain things regardless of +/-Asserts? (well, I know we were naming >> some things, but mostly

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

2016-03-14 Thread Benjamin Kramer via cfe-commits
On Mon, Mar 14, 2016 at 3:59 PM, David Blaikie wrote: > Yeah - how are they relying on them in a non-asserts build anyway? (were we > naming certain things regardless of +/-Asserts? (well, I know we were naming > some things, but mostly down in LLVM, I thought Clang generally used the > IRBuilder

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

2016-03-14 Thread David Blaikie via cfe-commits
Yeah - how are they relying on them in a non-asserts build anyway? (were we naming certain things regardless of +/-Asserts? (well, I know we were naming some things, but mostly down in LLVM, I thought Clang generally used the IRBuilder & thus didn't name things in non-Asserts builds)) On Mon, Mar

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

2016-03-14 Thread Chandler Carruth via cfe-commits
A long time ago I argued that the sanitizers should be using debug info instead of alloca names for this, and I really thought that they had implemented this... Is that not the case? It is really bad that the sanitizers are relying on this stuff... On Mon, Mar 14, 2016 at 2:28 PM Benjamin Kramer

r263429 - [Frontend] Disable value name discarding for all sanitizers.

2016-03-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Mar 14 08:23:58 2016 New Revision: 263429 URL: http://llvm.org/viewvc/llvm-project?rev=263429&view=rev Log: [Frontend] Disable value name discarding for all sanitizers. ASan also relies on names on allocas and will emit unhelpful output if they're not present. Just force-ena