Re: r266496 - [CUDA] Raise an error if the CUDA install can't be found.

Thanks! On Tue, Apr 19, 2016 at 11:58 AM Justin Lebar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Committed a test in r266796. > > On Tue, Apr 19, 2016 at 11:42 AM, Justin Lebar wrote: > >> I don't really understand why having to change the test when we change > the code it test chang

Re: r266496 - [CUDA] Raise an error if the CUDA install can't be found.

Committed a test in r266796. On Tue, Apr 19, 2016 at 11:42 AM, Justin Lebar wrote: >> I don't really understand why having to change the test when we change the >> code it test changes... > > My thought was, this code isn't really testing how we detect a CUDA > installation. That's a separate m

Re: r266496 - [CUDA] Raise an error if the CUDA install can't be found.

> I don't really understand why having to change the test when we change the > code it test changes... My thought was, this code isn't really testing how we detect a CUDA installation. That's a separate matter, involving --cuda-path, various default locations we check, and so on. Anyway I now s

Re: r266496 - [CUDA] Raise an error if the CUDA install can't be found.

I don't really understand why having to change the test when we change the code it test changes... We have several fake install trees in the driver tests to check pretty much exactly these kinds of things? On Tue, Apr 19, 2016 at 11:31 AM Justin Lebar via cfe-commits < cfe-commits@lists.llvm.org>

Re: r266496 - [CUDA] Raise an error if the CUDA install can't be found.

Yes, in general our testing story around the CUDA installs needs work. In particular, our wrapper headers are complicated and fragile, and have zero coverage at the moment. That's why Art is working on getting CUDA tests into the test-suite. It's possible to test this particular change without ac

Re: r266496 - [CUDA] Raise an error if the CUDA install can't be found.

This commit is missing a test. On Fri, Apr 15, 2016 at 5:16 PM Justin Lebar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jlebar > Date: Fri Apr 15 19:11:11 2016 > New Revision: 266496 > > URL: http://llvm.org/viewvc/llvm-project?rev=266496&view=rev > Log: > [CUDA] Raise an error

r266496 - [CUDA] Raise an error if the CUDA install can't be found.

Author: jlebar Date: Fri Apr 15 19:11:11 2016 New Revision: 266496 URL: http://llvm.org/viewvc/llvm-project?rev=266496&view=rev Log: [CUDA] Raise an error if the CUDA install can't be found. Summary: Without this change, we silently proceed on without including __clang_cuda_runtime_wrapper.h. Th