Re: r267054 - Split interesting warnings off from -Wfloat-conversion

On Fri, Apr 22, 2016 at 10:50 AM, David Blaikie wrote: > > > On Thu, Apr 21, 2016 at 2:04 PM, Richard Trieu via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rtrieu >> Date: Thu Apr 21 16:04:55 2016 >> New Revision: 267054 >> >> URL:

Re: r267054 - Split interesting warnings off from -Wfloat-conversion

Nico, With this warning, I was attempting to catch different cases of floating to bool conversion: bool x = 5.0; // Wrong type void test(bool, float); test(5.0, true); // Switched arguments. I did not see anything like your example come up. See as there are many edge cases in with

Re: r267054 - Split interesting warnings off from -Wfloat-conversion

On Thu, Apr 21, 2016 at 2:04 PM, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Thu Apr 21 16:04:55 2016 > New Revision: 267054 > > URL: http://llvm.org/viewvc/llvm-project?rev=267054=rev > Log: > Split interesting warnings off from -Wfloat-conversion

Re: r267054 - Split interesting warnings off from -Wfloat-conversion

Hi Richard, 1.) Are these new warnings in -Wconversion? If not, they probably should be, right? 2.) It looks like -Wfloat-bool-constant-conversion is on by default and warns on things like if (kHotspotRadius) if kHotspotRadius is a float. Do you have data that suggests that this is a common

r267054 - Split interesting warnings off from -Wfloat-conversion

Author: rtrieu Date: Thu Apr 21 16:04:55 2016 New Revision: 267054 URL: http://llvm.org/viewvc/llvm-project?rev=267054=rev Log: Split interesting warnings off from -Wfloat-conversion Restructure the implict floating point to integer conversions so that interesting sub-groups are under different