r267186 - Fix a bug involving deferred decl emission and PCH

2016-04-22 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Apr 22 13:46:33 2016 New Revision: 267186 URL: http://llvm.org/viewvc/llvm-project?rev=267186&view=rev Log: Fix a bug involving deferred decl emission and PCH For various reasons, involving dllexport and class linkage compuations, we have to wait until after the semicolon af

Re: r267186 - Fix a bug involving deferred decl emission and PCH

2016-04-22 Thread Richard Smith via cfe-commits
On Fri, Apr 22, 2016 at 11:46 AM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Fri Apr 22 13:46:33 2016 > New Revision: 267186 > > URL: http://llvm.org/viewvc/llvm-project?rev=267186&view=rev > Log: > Fix a bug involving deferred decl emission and PCH >

Re: r267186 - Fix a bug involving deferred decl emission and PCH

2016-04-22 Thread Reid Kleckner via cfe-commits
On Fri, Apr 22, 2016 at 12:29 PM, Richard Smith wrote: > On Fri, Apr 22, 2016 at 11:46 AM, Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rnk >> Date: Fri Apr 22 13:46:33 2016 >> New Revision: 267186 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=267186&view

Re: r267186 - Fix a bug involving deferred decl emission and PCH

2016-04-22 Thread Richard Smith via cfe-commits
On Fri, Apr 22, 2016 at 12:59 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Apr 22, 2016 at 12:29 PM, Richard Smith > wrote: > >> On Fri, Apr 22, 2016 at 11:46 AM, Reid Kleckner via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: rnk >>> Date:

Re: r267186 - Fix a bug involving deferred decl emission and PCH

2016-04-25 Thread Reid Kleckner via cfe-commits
On Fri, Apr 22, 2016 at 1:58 PM, Richard Smith wrote: > > This seems like a fragile thing to rely on. What about template > instantiation performed at end of TU? (I /think/ that case is currently > fine because all the kinds of template we instantiate ultimately do result > in a call to HandleTopL

Re: r267186 - Fix a bug involving deferred decl emission and PCH

2016-04-25 Thread Richard Smith via cfe-commits
On Mon, Apr 25, 2016 at 1:04 PM, Reid Kleckner wrote: > On Fri, Apr 22, 2016 at 1:58 PM, Richard Smith > wrote: >> >> This seems like a fragile thing to rely on. What about template >> instantiation performed at end of TU? (I /think/ that case is currently >> fine because all the kinds of templa