Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

2016-05-02 Thread Akira Hatanaka via cfe-commits
Thanks, fixed in r268318. > On May 2, 2016, at 3:05 PM, Richard Smith wrote: > > On Mon, May 2, 2016 at 2:52 PM, Akira Hatanaka via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: ahatanak > Date: Mon May 2 16:52:57 2016 > New Revision: 268314 > > URL: http://llvm.org/viewv

Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

2016-05-02 Thread Akira Hatanaka via cfe-commits
It looks like turning it to an assert wouldn’t be correct, I’ll probably just remove it. > On May 2, 2016, at 3:12 PM, Akira Hatanaka via cfe-commits > wrote: > > I see. Perhaps this should be an assert? > >> On May 2, 2016, at 3:05 PM, Richard Smith > > wrote: >

Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

2016-05-02 Thread Akira Hatanaka via cfe-commits
I see. Perhaps this should be an assert? > On May 2, 2016, at 3:05 PM, Richard Smith wrote: > > On Mon, May 2, 2016 at 2:52 PM, Akira Hatanaka via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: ahatanak > Date: Mon May 2 16:52:57 2016 > New Revision: 268314 > > URL: http:/

Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

2016-05-02 Thread Richard Smith via cfe-commits
On Mon, May 2, 2016 at 2:52 PM, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ahatanak > Date: Mon May 2 16:52:57 2016 > New Revision: 268314 > > URL: http://llvm.org/viewvc/llvm-project?rev=268314&view=rev > Log: > [CodeGenObjCXX] Don't rematerialize default argum

r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

2016-05-02 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Mon May 2 16:52:57 2016 New Revision: 268314 URL: http://llvm.org/viewvc/llvm-project?rev=268314&view=rev Log: [CodeGenObjCXX] Don't rematerialize default arguments of function parameters in the body of a block. This fixes a bug where clang would materialize the default ar