Author: bruno
Date: Tue May 10 13:43:00 2016
New Revision: 269100
URL: http://llvm.org/viewvc/llvm-project?rev=269100&view=rev
Log:
[VFS] Reconstruct the VFS overlay tree for more accurate lookup
The way we currently build the internal VFS overlay representation leads
to inefficient path search a
Hi Bruno,
I had to revert this in r269100 because it was looking like the bot was
going to be left red overnight.
Changes to this VFS code seem to have a trend of breaking on windows. Any
idea why that is? I can understand things breaking on windows when writing
low-level parts of an FS abstracti
Thanks Sean,
I was about to ask for help and try a 4th attempt, as you noted after
3 attempts I was not yet able to make this work on windows though...
The new tests I added first failed on windows because looks like a
missing "/" on the dir name forces "\\" to be generated while
appending the fi
On Tue, May 10, 2016 at 9:49 PM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> Thanks Sean,
>
> I was about to ask for help and try a 4th attempt, as you noted after
> 3 attempts I was not yet able to make this work on windows though...
>
So sorry! It had gone quiet for a few hours and
Hi Sean,
> So sorry! It had gone quiet for a few hours and I wanted to avoid leaving it
> red any longer.
No problem, the priority is to get bot greens!
> Does any platform define a guaranteed directory iteration order? I feel like
> depending on it in the first place is unwise (or maybe I'm mis
On Tue, May 10, 2016 at 11:14 PM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> Hi Sean,
>
> > So sorry! It had gone quiet for a few hours and I wanted to avoid
> leaving it
> > red any longer.
>
> No problem, the priority is to get bot greens!
>
> > Does any platform define a guaranteed
> I'm glad to help, but it makes me uneasy to have somebody working on a
> filesystem abstraction that does not have ready access to test and debug
> their changes across the major host platforms that LLVM supports (linux,
> mac, windows). Is there any way you can get access? I don't think that
> w
On Wed, May 11, 2016 at 10:46 AM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> > I'm glad to help, but it makes me uneasy to have somebody working on a
> > filesystem abstraction that does not have ready access to test and debug
> > their changes across the major host platforms that LLV
> What are the platform-specifics for crash reproducing? Shouldn't it
> basically be saving some files and storing some data for reconstructing?
Feature-wise the crash reproducer for modules could "just" work for
windows, there should not be anything platform-specific, I never
tested it on windows
