Re: r274628 - Include debug info for nested structs and classes

2016-07-08 Thread David Blaikie via cfe-commits
On Thu, Jul 7, 2016 at 4:22 PM, Adrian McCarthy wrote: > This patch was reverted because it breaks a test on the buildbots (that > I've been unable to reproduce locally), so that's why you didn't seen > anything. I'll try again to land the patch once I can fix and verify that > test. > > This pa

Re: r274628 - Include debug info for nested structs and classes

2016-07-07 Thread Adrian McCarthy via cfe-commits
This patch was reverted because it breaks a test on the buildbots (that I've been unable to reproduce locally), so that's why you didn't seen anything. I'll try again to land the patch once I can fix and verify that test. This patch is one part of the change. The other part is http://reviews.llv

Re: r274628 - Include debug info for nested structs and classes

2016-07-07 Thread David Blaikie via cfe-commits
Ah, I see why I might not've seen the result - it was reverted & I didn't spot the revert in a quick search for r274628 (because it was quoted as rL because Phab is weird and likes to put an "L" in there). On Thu, Jul 7, 2016 at 4:03 PM, David Blaikie wrote: > This may cause problems for DWA

Re: r274628 - Include debug info for nested structs and classes

2016-07-07 Thread David Blaikie via cfe-commits
This may cause problems for DWARF type unit consistency... Under what conditions do nested types appear in the member list? (my simple test case on a fresh clang didn't seem to produce anything about the nested type: struct outer { struct inner { int i; }; int j; }; outer o; ) On Wed, Jul 6, 2016

r274628 - Include debug info for nested structs and classes

2016-07-06 Thread Adrian McCarthy via cfe-commits
Author: amccarth Date: Wed Jul 6 09:46:42 2016 New Revision: 274628 URL: http://llvm.org/viewvc/llvm-project?rev=274628&view=rev Log: Include debug info for nested structs and classes This includes nested types in the member list, even if there are no members of that type. Note that structs and