Re: r274991 - [clang-cl] Add support for /Zd

2016-07-29 Thread Hans Wennborg via cfe-commits
On Fri, Jul 29, 2016 at 10:12 AM, Nico Weber wrote: > On Thu, Jul 28, 2016 at 9:03 PM, Hans Wennborg wrote: >> >> Sorry, I was supposed to chime in here. >> >> I don't have a strong opinion on this, but I don't think it's a >> problem for us to allow the -gline-tables-only spelling in addition to

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-29 Thread Nico Weber via cfe-commits
On Thu, Jul 28, 2016 at 9:03 PM, Hans Wennborg wrote: > Sorry, I was supposed to chime in here. > > I don't have a strong opinion on this, but I don't think it's a > problem for us to allow the -gline-tables-only spelling in addition to > /Zd. > > It just doesn't seem like a big deal to me. > Do

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-28 Thread Hans Wennborg via cfe-commits
Sorry, I was supposed to chime in here. I don't have a strong opinion on this, but I don't think it's a problem for us to allow the -gline-tables-only spelling in addition to /Zd. It just doesn't seem like a big deal to me. On Mon, Jul 11, 2016 at 5:50 PM, Saleem Abdulrasool via cfe-commits wro

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-11 Thread Saleem Abdulrasool via cfe-commits
On Mon, Jul 11, 2016 at 12:29 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Mon, Jul 11, 2016 at 12:18 PM, Nico Weber wrote: > >> On Mon, Jul 11, 2016 at 12:19 PM, David Majnemer < >> david.majne...@gmail.com> wrote: >> >>> >>> >>> On Mon, Jul 11, 2016 at 9:03 A

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-11 Thread David Majnemer via cfe-commits
On Mon, Jul 11, 2016 at 12:18 PM, Nico Weber wrote: > On Mon, Jul 11, 2016 at 12:19 PM, David Majnemer > wrote: > >> >> >> On Mon, Jul 11, 2016 at 9:03 AM, Nico Weber wrote: >> >>> On Mon, Jul 11, 2016 at 11:51 AM, David Majnemer < >>> david.majne...@gmail.com> wrote: >>> On Mon,

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-11 Thread Nico Weber via cfe-commits
On Mon, Jul 11, 2016 at 12:19 PM, David Majnemer wrote: > > > On Mon, Jul 11, 2016 at 9:03 AM, Nico Weber wrote: > >> On Mon, Jul 11, 2016 at 11:51 AM, David Majnemer < >> david.majne...@gmail.com> wrote: >> >>> >>> >>> On Mon, Jul 11, 2016 at 8:42 AM, Nico Weber wrote: >>> On Mon, Jul 11,

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-11 Thread David Majnemer via cfe-commits
On Mon, Jul 11, 2016 at 9:03 AM, Nico Weber wrote: > On Mon, Jul 11, 2016 at 11:51 AM, David Majnemer > wrote: > >> >> >> On Mon, Jul 11, 2016 at 8:42 AM, Nico Weber wrote: >> >>> On Mon, Jul 11, 2016 at 11:36 AM, David Majnemer < >>> david.majne...@gmail.com> wrote: >>> On Mon,

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-11 Thread Nico Weber via cfe-commits
On Mon, Jul 11, 2016 at 11:51 AM, David Majnemer wrote: > > > On Mon, Jul 11, 2016 at 8:42 AM, Nico Weber wrote: > >> On Mon, Jul 11, 2016 at 11:36 AM, David Majnemer < >> david.majne...@gmail.com> wrote: >> >>> >>> >>> On Mon, Jul 11, 2016 at 7:18 AM, Nico Weber wrote: >>> VS2013's cl.exe

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-11 Thread David Majnemer via cfe-commits
On Mon, Jul 11, 2016 at 8:42 AM, Nico Weber wrote: > On Mon, Jul 11, 2016 at 11:36 AM, David Majnemer > wrote: > >> >> >> On Mon, Jul 11, 2016 at 7:18 AM, Nico Weber wrote: >> >>> VS2013's cl.exe doesn't understand /Zd, 2015's doesn't either. This >>> means people who want to ask clang-cl for l

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-11 Thread Nico Weber via cfe-commits
On Mon, Jul 11, 2016 at 11:36 AM, David Majnemer wrote: > > > On Mon, Jul 11, 2016 at 7:18 AM, Nico Weber wrote: > >> VS2013's cl.exe doesn't understand /Zd, 2015's doesn't either. This means >> people who want to ask clang-cl for line tables only will have to add this >> flag in some if(is_clan

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-11 Thread David Majnemer via cfe-commits
On Mon, Jul 11, 2016 at 7:18 AM, Nico Weber wrote: > VS2013's cl.exe doesn't understand /Zd, 2015's doesn't either. This means > people who want to ask clang-cl for line tables only will have to add this > flag in some if(is_clang) block in their build file anyways. What's the > advantage of givi

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-11 Thread Nico Weber via cfe-commits
VS2013's cl.exe doesn't understand /Zd, 2015's doesn't either. This means people who want to ask clang-cl for line tables only will have to add this flag in some if(is_clang) block in their build file anyways. What's the advantage of giving this flag a spelling that's different from both cl and cla

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-11 Thread Nico Weber via cfe-commits
This breaks existing users of -gline-tables-only. What's the motivation for this change? On Sat, Jul 9, 2016 at 5:49 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: majnemer > Date: Sat Jul 9 16:49:16 2016 > New Revision: 274991 > > URL: http://llvm.org/viewvc/l

r274991 - [clang-cl] Add support for /Zd

2016-07-09 Thread David Majnemer via cfe-commits
Author: majnemer Date: Sat Jul 9 16:49:16 2016 New Revision: 274991 URL: http://llvm.org/viewvc/llvm-project?rev=274991&view=rev Log: [clang-cl] Add support for /Zd MASM (ML.exe and ML64.exe) and older versions of MSVC (CL.exe) support a flag called /Zd which is more-or-less -gline-tables-only.