Re: r277522 - [CFG] Fix crash finding destructor of lifetime-extended temporary.

2016-08-11 Thread Hans Wennborg via cfe-commits
Merged in r278376. Thanks, Hans On Thu, Aug 11, 2016 at 11:13 AM, Richard Smith wrote: > Well, the whole approach here is still wrong (per the FIXME in > CFGBuilder::addLocalScopeForVarDecl) but this at least makes it consistent. > Let's take this for 3.9 to at least stem

Re: r277522 - [CFG] Fix crash finding destructor of lifetime-extended temporary.

2016-08-11 Thread Richard Smith via cfe-commits
Well, the whole approach here is still wrong (per the FIXME in CFGBuilder::addLocalScopeForVarDecl) but this at least makes it consistent. Let's take this for 3.9 to at least stem the bleeding. On Tue, Aug 9, 2016 at 11:57 AM, Hans Wennborg wrote: > For the record, this was

Re: r277522 - [CFG] Fix crash finding destructor of lifetime-extended temporary.

2016-08-09 Thread Hans Wennborg via cfe-commits
For the record, this was for PR28666. Richard: what do you think about merging this to 3.9? On Tue, Aug 2, 2016 at 2:07 PM, Devin Coughlin via cfe-commits wrote: > Author: dcoughlin > Date: Tue Aug 2 16:07:23 2016 > New Revision: 277522 > > URL:

r277522 - [CFG] Fix crash finding destructor of lifetime-extended temporary.

2016-08-02 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Tue Aug 2 16:07:23 2016 New Revision: 277522 URL: http://llvm.org/viewvc/llvm-project?rev=277522=rev Log: [CFG] Fix crash finding destructor of lifetime-extended temporary. Fix a crash under -Wthread-safety when finding the destructor for a lifetime-extending reference.