r279486 - Fix regression introduced by r279164: only pass definitions as the PatternDef

2016-08-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Aug 22 17:25:03 2016 New Revision: 279486 URL: http://llvm.org/viewvc/llvm-project?rev=279486&view=rev Log: Fix regression introduced by r279164: only pass definitions as the PatternDef to DiagnoseUninstantiableTemplate, teach hasVisibleDefinition to correctly determine wh

Re: r279486 - Fix regression introduced by r279164: only pass definitions as the PatternDef

2016-08-22 Thread Chandler Carruth via cfe-commits
Reverted this per Richard's request in r279500. On Mon, Aug 22, 2016 at 3:33 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Aug 22 17:25:03 2016 > New Revision: 279486 > > URL: http://llvm.org/viewvc/llvm-project?rev=279486&view=rev > Log: > Fix

Re: r279486 - Fix regression introduced by r279164: only pass definitions as the PatternDef

2016-08-23 Thread Richard Smith via cfe-commits
Thanks. Fixed and reapplied as r279557. On Mon, Aug 22, 2016 at 7:08 PM, Chandler Carruth wrote: > Reverted this per Richard's request in r279500. > > > On Mon, Aug 22, 2016 at 3:33 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Mon Aug 22 17

Re: r279486 - Fix regression introduced by r279164: only pass definitions as the PatternDef

2016-08-23 Thread Vassil Vassilev via cfe-commits
Thanks a lot! On 23/08/16 22:50, Richard Smith via cfe-commits wrote: Thanks. Fixed and reapplied as r279557. On Mon, Aug 22, 2016 at 7:08 PM, Chandler Carruth > wrote: Reverted this per Richard's request in r279500. On Mon, Aug 22, 2016 at 3:33 PM Richard