Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

2016-09-09 Thread Manman Ren via cfe-commits
Committed r281119. Let me know if you see any problem. Cheers, Manman On Fri, Sep 9, 2016 at 12:07 PM, Manman Ren wrote: > > > On Fri, Sep 9, 2016 at 11:33 AM, Richard Smith > wrote: > >> On Fri, Sep 9, 2016 at 11:29 AM, Manman Ren via cfe-commits

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

2016-09-09 Thread Manman Ren via cfe-commits
On Fri, Sep 9, 2016 at 11:33 AM, Richard Smith wrote: > On Fri, Sep 9, 2016 at 11:29 AM, Manman Ren via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Wed, Sep 7, 2016 at 4:44 PM, Richard Smith >> wrote: >> >>> On Wed, Sep 7, 2016 at

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

2016-09-09 Thread Richard Smith via cfe-commits
On Fri, Sep 9, 2016 at 11:29 AM, Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Sep 7, 2016 at 4:44 PM, Richard Smith > wrote: > >> On Wed, Sep 7, 2016 at 12:45 PM, Manman Ren wrote: >> >>> On Tue, Sep 6, 2016 at 6:54 PM,

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

2016-09-09 Thread Manman Ren via cfe-commits
On Wed, Sep 7, 2016 at 4:44 PM, Richard Smith wrote: > On Wed, Sep 7, 2016 at 12:45 PM, Manman Ren wrote: > >> On Tue, Sep 6, 2016 at 6:54 PM, Richard Smith >> wrote: >> >>> On Tue, Sep 6, 2016 at 11:16 AM, Manman Ren via

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

2016-09-07 Thread Richard Smith via cfe-commits
On Wed, Sep 7, 2016 at 12:45 PM, Manman Ren wrote: > On Tue, Sep 6, 2016 at 6:54 PM, Richard Smith > wrote: > >> On Tue, Sep 6, 2016 at 11:16 AM, Manman Ren via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: mren >>> Date: Tue Sep

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

2016-09-07 Thread Manman Ren via cfe-commits
On Tue, Sep 6, 2016 at 6:54 PM, Richard Smith wrote: > On Tue, Sep 6, 2016 at 11:16 AM, Manman Ren via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: mren >> Date: Tue Sep 6 13:16:54 2016 >> New Revision: 280728 >> >> URL:

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

2016-09-06 Thread Richard Smith via cfe-commits
On Tue, Sep 6, 2016 at 11:16 AM, Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mren > Date: Tue Sep 6 13:16:54 2016 > New Revision: 280728 > > URL: http://llvm.org/viewvc/llvm-project?rev=280728=rev > Log: > Modules: Fix an assertion in DeclContext::buildLookup. > >

r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

2016-09-06 Thread Manman Ren via cfe-commits
Author: mren Date: Tue Sep 6 13:16:54 2016 New Revision: 280728 URL: http://llvm.org/viewvc/llvm-project?rev=280728=rev Log: Modules: Fix an assertion in DeclContext::buildLookup. When calling getMostRecentDecl, we can pull in more definitions from a module. We call getPrimaryContext afterwards