Re: r281057 - [DebugInfo] Ensure complete type is emitted with -fstandalone-debug

2016-09-12 Thread Reid Kleckner via cfe-commits
On Mon, Sep 12, 2016 at 11:41 AM, David Blaikie wrote: > (idle thought: It'd be good to make the code common between the first time > a type is encountered, and the later callbacks when the type is completed, > required to be complete, vtable is emitted, etc - the

Re: r281057 - [DebugInfo] Ensure complete type is emitted with -fstandalone-debug

2016-09-12 Thread David Blaikie via cfe-commits
Looks like this test could be a bit simpler: struct foo; foo *f; // produces a forward decl struct foo { virtual ~foo(); }; foo f; // requires the type to be complete A cursory glance looks like this reproduces the issue, but I may've missed something. Also the bracing in the new condition

r281057 - [DebugInfo] Ensure complete type is emitted with -fstandalone-debug

2016-09-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Sep 9 12:03:53 2016 New Revision: 281057 URL: http://llvm.org/viewvc/llvm-project?rev=281057=rev Log: [DebugInfo] Ensure complete type is emitted with -fstandalone-debug The logic for upgrading a class from a forward decl to a complete type was not checking the debug info