Re: r287343 - [OpenCL] Introduce ReadPipeType and WritePipeType.

Hi Yaron, I have changed how I implemented this, will open a review soon. Thanks, Joey On 21 November 2016 at 14:42, Yaron Keren wrote: > Hi Joey, > > In order for ReadPipeType and WritePipeType to work with LLVM type system > (isa, dyn_cast), you need to modify the

Re: r287343 - [OpenCL] Introduce ReadPipeType and WritePipeType.

Hi Joey, In order for ReadPipeType and WritePipeType to work with LLVM type system (isa, dyn_cast), you need to modify the existing TypeClass::Pipe kind into TypeClass::ReadPipe and TypeClass::WritePipe, have Pipe::classof recognize both kinds and have ReadPipe::classof and WritePipe::classof

r287343 - [OpenCL] Introduce ReadPipeType and WritePipeType.

Author: joey Date: Fri Nov 18 08:10:54 2016 New Revision: 287343 URL: http://llvm.org/viewvc/llvm-project?rev=287343=rev Log: [OpenCL] Introduce ReadPipeType and WritePipeType. This allows Sema to diagnose passing a read_only pipe to a write_only pipe argument. Modified: