r290569 - Driver: switch Windows to static RelocModel

2016-12-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Dec 26 20:20:35 2016 New Revision: 290569 URL: http://llvm.org/viewvc/llvm-project?rev=290569&view=rev Log: Driver: switch Windows to static RelocModel Windows uses PE/COFF which is inherently position independent. The use of the PIC model is unnecessary. In fact, we

Re: r290569 - Driver: switch Windows to static RelocModel

2016-12-28 Thread Reid Kleckner via cfe-commits
I suspect this broke Win64: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/1410 On Mon, Dec 26, 2016 at 6:20 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Mon Dec 26 20:20:35 2016 > New Revision: 290569 > > URL: http://llvm.o

Re: r290569 - Driver: switch Windows to static RelocModel

2016-12-28 Thread Reid Kleckner via cfe-commits
This affected code generation of jump tables from switches. This was the assembly difference for a switch when going from PIC to static: $ cat t.cpp void g(int); void f(int x) { switch (x) { case 0: g(0); break; case 1: g(1); break; case 2: g(2); break; case 3: g(3); break; case 4: g(4

Re: r290569 - Driver: switch Windows to static RelocModel

2016-12-28 Thread Reid Kleckner via cfe-commits
I filed https://llvm.org/bugs/show_bug.cgi?id=31488 for this. On Wed, Dec 28, 2016 at 9:37 AM, Reid Kleckner wrote: > This affected code generation of jump tables from switches. This was the > assembly difference for a switch when going from PIC to static: > > $ cat t.cpp > void g(int); > void f