Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

2017-01-21 Thread Björn Pettersson A via cfe-commits
Hello Antonio and Mikael. I've tried reproducing this also after removal of the redundant test (D28943), and I still see the fail for CHECK10. The problem is that we (both me an Mikael) are running this test from inside our llvm repo (with build artifacts ending up in a "build-all" directory

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

2017-01-20 Thread Antonio Maiorano via cfe-commits
Hello Mikael, Did you try again with the removal of the redundant test (D28943)? On Fri, 20 Jan 2017 at 08:34 Mikael Holmén wrote: > Hi, > > On 01/20/2017 02:20 PM, Antonio Maiorano wrote: > > Hi Mikael, > > > > Just to be sure, did you build clang-format before

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

2017-01-20 Thread Mikael Holmén via cfe-commits
Hi, On 01/20/2017 02:20 PM, Antonio Maiorano wrote: Hi Mikael, Just to be sure, did you build clang-format before running this test? Yes I did. I compiled a clean trunk, ran the test, got the failure. Possibly related, one of the tests I added was just removed for being redundant:

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

2017-01-20 Thread Antonio Maiorano via cfe-commits
Hi Mikael, Just to be sure, did you build clang-format before running this test? Possibly related, one of the tests I added was just removed for being redundant: https://reviews.llvm.org/D28943 On Fri, Jan 20, 2017 at 7:50 AM Mikael Holmén wrote: > Hi Antonio, > >

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

2017-01-20 Thread Mikael Holmén via cfe-commits
Hi Antonio, The test case Clang :: Format/style-on-command-line.cpp fails for me since this commit. test/Format/style-on-command-line.cpp:40:13: error: expected string not found in input // CHECK10: {{^int\* i;$}} ^ :1:1: note: scanning from here // RUN: clang-format

r292562 - clang-format: fix fallback style set to "none" not always formatting

2017-01-19 Thread Antonio Maiorano via cfe-commits
Author: amaiorano Date: Thu Jan 19 19:22:42 2017 New Revision: 292562 URL: http://llvm.org/viewvc/llvm-project?rev=292562=rev Log: clang-format: fix fallback style set to "none" not always formatting This fixes clang-format not formatting if fallback-style is explicitly set to "none", and either