Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

2017-06-26 Thread Akira Hatanaka via cfe-commits
This should be fixed in r306364. > On Jun 22, 2017, at 1:26 PM, Akira Hatanaka wrote: > > According to the documentation, the starting position of the field has to be > encoded too: > > https://gcc.gnu.org/onlinedocs/gcc/Type-encoding.html >

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

2017-06-22 Thread Akira Hatanaka via cfe-commits
According to the documentation, the starting position of the field has to be encoded too: https://gcc.gnu.org/onlinedocs/gcc/Type-encoding.html I’m not sure whether we need the same information for bitfield ivars though. > On Jun 22,

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

2017-06-22 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jun 22, 2017 at 11:09:48AM -0700, Akira Hatanaka wrote: > Do you want the same encoding for the bitfield “int : 1” you saw before > r297792, which is just “i"? > > The encoding for bitfield is normally bN where N is the number of bits, > but the comment in function EncodeBitField says

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

2017-06-22 Thread Akira Hatanaka via cfe-commits
Do you want the same encoding for the bitfield “int : 1” you saw before r297792, which is just “i"? The encoding for bitfield is normally bN where N is the number of bits, but the comment in function EncodeBitField says GNU runtime encodes it differently. > On Jun 22, 2017, at 8:30 AM, Joerg

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

2017-06-22 Thread Joerg Sonnenberger via cfe-commits
On Mon, Jun 12, 2017 at 09:03:10PM +0200, Joerg Sonnenberger wrote: > On Thu, Jun 01, 2017 at 05:58:41PM -0700, Akira Hatanaka wrote: > > It crashes when there is an anonymous ivar of a bitfield type. > > > > @interface FormatScanner { > > int : 1; > > } > > @end > > > > @implementation

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

2017-06-12 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jun 01, 2017 at 05:58:41PM -0700, Akira Hatanaka wrote: > It crashes when there is an anonymous ivar of a bitfield type. > > @interface FormatScanner { > int : 1; > } > @end > > @implementation FormatScanner > @end > > I'm not sure if the code above is valid or not, but out of

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

2017-06-01 Thread Joerg Sonnenberger via cfe-commits
On Tue, Mar 14, 2017 at 04:00:53AM -, Akira Hatanaka via cfe-commits wrote: > Author: ahatanak > Date: Mon Mar 13 23:00:52 2017 > New Revision: 297702 > > URL: http://llvm.org/viewvc/llvm-project?rev=297702=rev > Log: > [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded >

r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

2017-03-13 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Mon Mar 13 23:00:52 2017 New Revision: 297702 URL: http://llvm.org/viewvc/llvm-project?rev=297702=rev Log: [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded correctly. This fixes PR30413. Patch by David Lobron. Added: