01449 - PPCallbacks::MacroUndefined, change signature and add
test.
And I reverted my revert in r301472. See the thread re: r301470.
Sorry for the noise,
vedant
> On Apr 26, 2017, at 2:12 PM, Vedant Kumar via cfe-commits
> wrote:
>
> Hi Frederich,
>
> I had to revert this to unblock mys
And I reverted my revert in r301472. See the thread re: r301470.
Sorry for the noise,
vedant
> On Apr 26, 2017, at 2:12 PM, Vedant Kumar via cfe-commits
> wrote:
>
> Hi Frederich,
>
> I had to revert this to unblock myself (r301469).
>
> best,
> vedant
>
>> On Apr 26, 2017, at 1:51 PM, Evge
Hi Frederich,
I had to revert this to unblock myself (r301469).
best,
vedant
> On Apr 26, 2017, at 1:51 PM, Evgenii Stepanov via cfe-commits
> wrote:
>
> Please change the signature of all overriding definitions as well.
>
> /code/llvm/tools/clang/lib/CodeGen/MacroPPCallbacks.h:114:50: error
Please change the signature of all overriding definitions as well.
/code/llvm/tools/clang/lib/CodeGen/MacroPPCallbacks.h:114:50: error:
non-virtual member function marked 'override' hides virtual member
function
const MacroDefinition &MD) override;
The bots are red, e.g.
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/4342
On Wed, Apr 26, 2017 at 12:47 PM, Frederich Munch via cfe-commits
wrote:
> Author: marsupial
> Date: Wed Apr 26 14:47:31 2017
> New Revision: 301449
>
> URL: http://llvm.org/viewvc/llvm-project?rev=301
Author: marsupial
Date: Wed Apr 26 14:47:31 2017
New Revision: 301449
URL: http://llvm.org/viewvc/llvm-project?rev=301449&view=rev
Log:
PPCallbacks::MacroUndefined, change signature and add test.
Summary:
The PPCallbacks::MacroUndefined callback is currently insufficient for clients
that need to
