Re: r310436 - [AST] Move visibility computations into a class; NFC

Okay, apparently release_capability doesn't work how I assumed, so it looks like this may be a bug in r310403. Pinged that thread. On Thu, Aug 10, 2017 at 3:24 PM, George Burgess IV wrote: > Following up, >

Re: r310436 - [AST] Move visibility computations into a class; NFC

Following up, http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_check/4070/console no longer shows ubsan failures. Looks like the attempt to fix Driver/openmp-offload.c is in r310580 (the linked build was r310538). The libc++ test failures all seem to be a result of -Werror clang

Re: r310436 - [AST] Move visibility computations into a class; NFC

Sorry about that! Attempted fix is r310523. I'll keep an eye on the bot to make sure it turns green. On Wed, Aug 9, 2017 at 1:23 PM, Juergen Ributzka wrote: > This seems to cause UBSAN issues: > > runtime error: load of value 4294967295, which is not a valid value for type

Re: r310436 - [AST] Move visibility computations into a class; NFC

This seems to cause UBSAN issues: runtime error: load of value 4294967295, which is not a valid value for type 'clang::LVComputationKind' See ASAN+UBSAN bot on Green Dragon: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/4065/console On Tue, Aug 8, 2017 at 9:02 PM, George

r310436 - [AST] Move visibility computations into a class; NFC

Author: gbiv Date: Tue Aug 8 21:02:49 2017 New Revision: 310436 URL: http://llvm.org/viewvc/llvm-project?rev=310436=rev Log: [AST] Move visibility computations into a class; NFC This is patch 1 in a 2 patch series that aims to fix PR29160. Its goal is to cache decl visibility/linkage for the