On Wed, Aug 9, 2017 at 10:11 AM, Gábor Horváth wrote:
> Sure!
>
> There was a follow-up patch that excluded anonymous enums. Is it still
> that bad to introduce it under a new flag?
>
The follow-up was at r310468. https://build.chromium.org/p/chromium.fyi/
On Wed, Aug 9, 2017 at 10:07 AM, Nico Weber via cfe-commits
wrote:
> Any way we could put this behind a different flag (say,
> -Wenum-compare-switch, in the same group as -Wenum-compare, so that
> -W(no-)enum-compare affects both)? Our codebase was -Wenum-compare clean
Sure!
There was a follow-up patch that excluded anonymous enums. Is it still that
bad to introduce it under a new flag?
Regards,
Gábor
On 9 August 2017 at 16:07, Nico Weber wrote:
> Any way we could put this behind a different flag (say,
> -Wenum-compare-switch, in the
Any way we could put this behind a different flag (say,
-Wenum-compare-switch, in the same group as -Wenum-compare, so that
-W(no-)enum-compare affects both)? Our codebase was -Wenum-compare clean
before this commit but is very not clean now, so we'd now have to disable
-Wenum-compare altogether,
Author: xazax
Date: Wed Aug 9 01:57:09 2017
New Revision: 310449
URL: http://llvm.org/viewvc/llvm-project?rev=310449=rev
Log:
[Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch
statements
Patch by: Reka Nikolett Kovacs
Differential Revision: